Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also set resource k8s limits/requests on the apply job #1553

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Also set resource k8s limits/requests on the apply job #1553

merged 2 commits into from
Nov 13, 2024

Conversation

ronaldvb-k
Copy link
Contributor

The plan job has k8s resources as specified in our Helm values, but the apply job doesn't use them.
This PR should fix this.

terranetes-controller:
  controller:
    extraArgs:
      executor-cpu-limit: 1
      executor-cpu-request: 5m
      executor-memory-limit: 2Gi
      executor-memory-request: 32Mi

Plan:

$ k -n terraform-system get po resource.acr-plan-8tndq-vkgtk -ojsonpath='{.spec.containers[0].resources}' | yq -P
limits:
  cpu: "1"
  memory: 2Gi
requests:
  cpu: 5m
  memory: 32Mi

Apply:

$ k -n terraform-system get po resource.acr-apply-hgtmw-hxslf -ojsonpath='{.spec.containers[0].resources}'|yq -P
requests:
  cpu: "0"
  memory: "0"

gambol99 and others added 2 commits November 10, 2024 17:30
@gambol99
[HELM] - Job Label Chart Fix (appvia#1551)
4c01e9d 
The current helm chart has a typo in the 'controller.jobsLabels', this should have been 'controller.jobLabels', which is what the actual template references
@ronaldvb-k
Also set resource k8s limits/requests on the apply job
7c4c263
@ronaldvb-k ronaldvb-k requested a review from gambol99 as a code owner November 11, 2024 14:24
@gambol99 gambol99 changed the base branch from master to develop November 11, 2024 17:19
gambol99
gambol99 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@gambol99 gambol99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM … thank you @ronaldvb-k

@gambol99 gambol99 merged commit d039b61 into appvia:develop Nov 13, 2024
9 checks passed
gambol99 added a commit that referenced this pull request Nov 15, 2024
@ronaldvb-k @gambol99
Also set resource k8s limits/requests on the apply job (#1553)
a5df2ac 
* [HELM] - Job Label Chart Fix (#1551)

The current helm chart has a typo in the 'controller.jobsLabels', this should have been 'controller.jobLabels', which is what the actual template references

* Also set resource k8s limits/requests on the apply job

---------

Co-authored-by: Rohith Jayawardene <[email protected]>
@gambol99 gambol99 mentioned this pull request Nov 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gambol99 gambol99 gambol99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronaldvb-k @gambol99