Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically log in if my token is expired #43

Open
bartTC opened this issue Oct 11, 2022 · 1 comment
Open

Automatically log in if my token is expired #43

bartTC opened this issue Oct 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@bartTC
Copy link

bartTC commented Oct 11, 2022

Right now, if your auth token is expired, you learn that via a message. I don't need the extra step, I don't see why you won't want to login at this point.

So this:

❯ apppack config list -a sampleapp
⚠ unable to refresh auth token {"error":"invalid_grant","error_description":"Unknown or invalid refresh token."}
ℹ Reauthenticate this device by running: apppack auth login

❯ apppack auth login
Your verification code is MRJL-VJLX
Finish authentication in your web browser...
✔ Logged in as [email protected]

Should become:

❯ apppack config list -a sampleapp
⚠ unable to refresh auth token {"error":"invalid_grant","error_description":"Unknown or invalid refresh token."}

ℹ Reauthenticate this required. Please login in your webbrowser.
Your verification code is MRJL-VJLX
Finish authentication in your web browser...
✔ Logged in as [email protected]

@bartTC bartTC added the enhancement New feature or request label Oct 11, 2022
@ipmb
Copy link
Member

ipmb commented Oct 23, 2022

My only concern with this is if people are using the CLI as part of an automated/unattended script. I'm curious if we can use https://github.com/mattn/go-isatty (which is already a dependency) to detect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants