Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-bs-autobatch can't be built due to undefined blockstore.ErrNotFound #2

Closed
fbac opened this issue Aug 16, 2022 · 1 comment
Closed

go-bs-autobatch can't be built due to undefined blockstore.ErrNotFound #2

fbac opened this issue Aug 16, 2022 · 1 comment
Assignees
@alvin-reyes

Comments

@fbac
Copy link

fbac commented Aug 16, 2022

go-bs-autobatch can't be built due to undefined blockstore.ErrNotFound functions called:

# github.com/application-research/go-bs-autobatch
../../../go/pkg/mod/github.com/application-research/[email protected]/autobatch.go:216:34: undefined: blockstore.ErrNotFound
../../../go/pkg/mod/github.com/application-research/[email protected]/autobatch.go:238:34: undefined: blockstore.ErrNotFound
../../../go/pkg/mod/github.com/application-research/[email protected]/autobatch.go:395:33: undefined: blockstore.ErrNotFound

Additional context
blockstore changed its way to raise ErrNotFound since this PR, which breaks compatibility.

The logic should be changed to use ipld.ErrNotFound instead of blockstore.ErrNotFound.
@alvin-reyes
Copy link

Resolved by the latest release here

https://github.com/application-research/go-bs-autobatch/releases/tag/v0.1.0

@alvin-reyes alvin-reyes self-assigned this Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvin-reyes alvin-reyes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alvin-reyes @fbac