Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quirks/websites-with-shared-credential-backends.json should be removed #825

Open
erynofwales opened this issue Sep 27, 2024 · 5 comments
Open
Assignees

Comments

@erynofwales
Copy link
Collaborator

quirks/websites-with-shared-credential-backends.json is a legacy data file that has been replaced by quirks/shared-credentials.json. We should remove it.

@rmondello rmondello self-assigned this Sep 27, 2024
@rmondello
Copy link
Contributor

Yeah, I think it's time. My plan for this is to change the script that converts to the legacy format to take a required output path, then remove the legacy file. Then any password manager who still wants to use the legacy format can use the script on their side, instead of making all contributors do the conversion.

How does this sound? @Cldfire @bradcush

@bradcush
Copy link
Collaborator

bradcush commented Oct 1, 2024

Yea that makes sense, I'm for it. Also thinking out loud that It could be beneficial adding a few small test cases to the CI at some point later since there will no longer be any trace of an artifact in the repository to manually check against. Just to make sure it's working given any kind of updates and it can also serve as a doc for the old format.

@Cldfire
Copy link
Collaborator

Cldfire commented Oct 1, 2024

@rmondello that sounds good to me!

(Do note however that I no longer work at 1Password, so I can't speak for them.)

@rmondello
Copy link
Contributor

@Cldfire Oh gosh, I'm so embarrassed! My apologies! (But thank you for chiming in regardless.)

@Cldfire
Copy link
Collaborator

Cldfire commented Oct 1, 2024

Oh no worries at all! I just wanted to make sure I clarified 😄

rmondello added a commit to rmondello/password-manager-resources that referenced this issue Nov 6, 2024
…apple#825

Remove the file, remove references to the file, and update scripts that referenced it.
rmondello added a commit to rmondello/password-manager-resources that referenced this issue Nov 6, 2024
…apple#825

Remove the file, remove references to the file, and update scripts that referenced it.
rmondello added a commit to rmondello/password-manager-resources that referenced this issue Nov 6, 2024
…apple#825

Remove the file, remove references to the file, and update scripts that referenced it.
rmondello added a commit to rmondello/password-manager-resources that referenced this issue Nov 6, 2024
…apple#825

Remove the file, remove references to the file, and update scripts that referenced it.
rmondello added a commit that referenced this issue Nov 11, 2024
…#825 (#850)

Remove the file, remove references to the file, and update scripts that referenced it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants