-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quirks/websites-with-shared-credential-backends.json should be removed #825
Comments
Yeah, I think it's time. My plan for this is to change the script that converts to the legacy format to take a required output path, then remove the legacy file. Then any password manager who still wants to use the legacy format can use the script on their side, instead of making all contributors do the conversion. |
Yea that makes sense, I'm for it. Also thinking out loud that It could be beneficial adding a few small test cases to the CI at some point later since there will no longer be any trace of an artifact in the repository to manually check against. Just to make sure it's working given any kind of updates and it can also serve as a doc for the old format. |
@rmondello that sounds good to me! (Do note however that I no longer work at 1Password, so I can't speak for them.) |
@Cldfire Oh gosh, I'm so embarrassed! My apologies! (But thank you for chiming in regardless.) |
Oh no worries at all! I just wanted to make sure I clarified 😄 |
…apple#825 Remove the file, remove references to the file, and update scripts that referenced it.
…apple#825 Remove the file, remove references to the file, and update scripts that referenced it.
…apple#825 Remove the file, remove references to the file, and update scripts that referenced it.
…apple#825 Remove the file, remove references to the file, and update scripts that referenced it.
quirks/websites-with-shared-credential-backends.json is a legacy data file that has been replaced by quirks/shared-credentials.json. We should remove it.
The text was updated successfully, but these errors were encountered: