Add a password rule for citiretailservices.citibankonline.com #617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Checklist
for password-rules.json
I wanted to give the password rules for citiretailservices.citibankonline.com a go. The rules differ from citi.com (#605). Password rules for Citi retail services seem to appear in two issues, #585 and #611. I have copied over the screenshot and video showing the password rules from the respective issues.
FullSizeRender.MOV
Rules
Here is a textual version of the rules:
Additional quirks
The password rules demand that two spaces should not appear consecutively. I could not find a way to express that in the password rules language. To avoid specifying a general
max-consecutive: 2
, I decided to not includespace
in theallowed
custom character class.The password rules disallow a good number of special characters. I have added all the
special
characters specified in the customizing password autofill rules documentation that were not explicitly disallowed by the password rules.@snicolai-blog and @jcordeal, would you be able to help test the validity of the new password rule?
Thanks in advance :)
Closes #585
Closes #611