Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mjpegscalingfactor changes back to default on change of orientation #450

Open
Eashwary opened this issue Jan 12, 2021 · 1 comment
Open

Comments

@Eashwary
Copy link

Eashwary commented Jan 12, 2021

The default value of mjpegscalingfactor set in WDA is 100. I will change the scalingfactor to 30 using appium/setting endpoint.
But if I change the orientation of the device from portrait to landscape using setorientation endpoint the scalingfactor is changed back to its default value(100). If I change orientation again to portrait then the scalingfactor is 30 as I had set before. Can you please tell me where, how, and why the scalingfactor is changing into default value on change of device orientation

@KazuCocoa
Copy link
Member

Need to debug the reason, but we simply store the value as static

+ (NSUInteger)mjpegScalingFactor
{
return FBMjpegScalingFactor;
}
+ (void)setMjpegScalingFactor:(NSUInteger)scalingFactor {
FBMjpegScalingFactor = scalingFactor;
}

Mjpegserver refers to it as

CGFloat scalingFactor = [FBConfiguration mjpegScalingFactor] / 100.0f;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants