Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label is wrongly placed for some search text #46

Open
winterflame opened this issue Apr 9, 2016 · 5 comments
Open

label is wrongly placed for some search text #46

winterflame opened this issue Apr 9, 2016 · 5 comments

Comments

@winterflame
Copy link

Mac 10.11.4 + FF45.0.1

  1. open https://www.topcoder-qa.com/search/members/?q=acRush
  2. observe

expected: the label should be put on the top of the results table

actual: see screenshot
qq20160409-54 2x

@callmekatootie
Copy link

It's a feature - iirc, if there is an exact match, then it shows the user itself - no title needed in such a case

@winterflame
Copy link
Author

@callmekatootie It shows the label as "Usernames matching acrush - 2 results", but there is only one result below the label, which is a bit confusing.

I still think it needs to be redesigned no matter if it has an exact match, please reconsider. Thanks!

@nlitwin
Copy link
Contributor

nlitwin commented Apr 12, 2016

I had thought about this as well, but forgot to mention it when building it. @fnisen @vic-appirio Is this working as expected or is it a valid bug?

@fnisen fnisen reopened this Apr 12, 2016
@fnisen fnisen added bug and removed invalid labels Apr 12, 2016
@fnisen
Copy link

fnisen commented Apr 12, 2016

@callmekatootie, @nlitwin - let's give credit for this one. Even if we don't need the label at the top, the label on the second component should still be corrected.

@nlitwin nlitwin added the todo label Apr 15, 2016
@nlitwin
Copy link
Contributor

nlitwin commented Apr 15, 2016

TODO: If exact match exists, show "Other usernames matching" for the list container header text and show one fewer than the actual number of list items.

@nlitwin nlitwin added help wanted and removed todo labels Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants