-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
label is wrongly placed for some search text #46
Comments
It's a feature - iirc, if there is an exact match, then it shows the user itself - no title needed in such a case |
@callmekatootie It shows the label as "Usernames matching acrush - 2 results", but there is only one result below the label, which is a bit confusing. I still think it needs to be redesigned no matter if it has an exact match, please reconsider. Thanks! |
I had thought about this as well, but forgot to mention it when building it. @fnisen @vic-appirio Is this working as expected or is it a valid bug? |
@callmekatootie, @nlitwin - let's give credit for this one. Even if we don't need the label at the top, the label on the second component should still be corrected. |
TODO: If exact match exists, show "Other usernames matching" for the list container header text and show one fewer than the actual number of list items. |
Mac 10.11.4 + FF45.0.1
expected: the label should be put on the top of the results table
actual: see screenshot
The text was updated successfully, but these errors were encountered: