Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String.slice and ranges - changed behaviour in Elixir 1.16.0 #57

Open
drobban opened this issue Jan 18, 2024 · 1 comment
Open

String.slice and ranges - changed behaviour in Elixir 1.16.0 #57

drobban opened this issue Jan 18, 2024 · 1 comment

Comments

@drobban
Copy link

drobban commented Jan 18, 2024

warning: negative steps are not supported in String.slice/2, pass 1..-1//1 instead
(elixir 1.16.0) lib/string.ex:2368: String.slice/2

The change is as I can understand and conclude from testing backwards compatible.
drobban added a commit to drobban/exconstructor that referenced this issue Jan 18, 2024
@drobban
Fixes warning caused by 1..-1
998dcee 
Related to upstream issue appcues#57
@drobban drobban mentioned this issue Jan 18, 2024
Closed
@drobban
Copy link
Author

drobban commented Jan 18, 2024

Noticed fix already in as PR.

Can confirm pull request #55 works as it should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drobban