Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batching support #7

Open
adampresley opened this issue Jan 17, 2020 · 0 comments
Open

Add batching support #7

adampresley opened this issue Jan 17, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@adampresley
Copy link
Collaborator

In Fireplace Server, add the ability to accept a set of log entries to write as a batch. The batch is nothing more than just an array of discreet log entries. This can help reduce the chattiness of the API and lower the amount of HTTP traffic.

Libraries must be updated to add support for this. Essentially when initializing a logger a user must be able to specify they want batched logging and how big the batch is before transmitting.

Please note that the size of the batch isn't the only trigger to send logs to the server. Time should also be a factor. This ensures that batches that aren't full don't get stuck in limbo and never sent. For example, let's say you configure a batch size of 10, and the application hasn't logged anything in 20 minutes. At some point these logs should be shipped to the server (every 30 seconds, as an example).

@adampresley adampresley added the enhancement New feature or request label Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant