Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Intrinsics value setter #47

Open
apowers313 opened this issue Mar 9, 2021 · 0 comments
Open

Refactor Intrinsics value setter #47

apowers313 opened this issue Mar 9, 2021 · 0 comments
Labels
priority:medium 🐞 type:bug Error. Does not compute.

Comments

@apowers313
Copy link
Owner

The setter for Intrinsics value calls sendEvent but doesn't return the resulting Promise, causing breakpoints to break. The value setter should be replaced with setValue that returns a Promise and the nethack Intrinsics should return the Promise as well.
@apowers313 apowers313 added 🐞 type:bug Error. Does not compute. priority:medium labels Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:medium 🐞 type:bug Error. Does not compute.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apowers313