Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New HTTP request execution API #6038

Closed
hwillson opened this issue Jan 26, 2022 · 1 comment
Closed

New HTTP request execution API #6038

hwillson opened this issue Jan 26, 2022 · 1 comment
Assignees
@glasser
Milestone
Release 4.0

Comments

@hwillson
Copy link
Member

hwillson commented Jan 26, 2022 •
edited by glasser
Loading

Full details in https://github.com/apollographql/apollo-server/blob/main/ROADMAP.md

This is all described well in #3184, though that also covers some other issues in the 4.0 milestone..
@hwillson hwillson added the ⛲️ feature New addition or enhancement to existing solutions label Jan 26, 2022
@hwillson hwillson added this to the Release 4.0 milestone Jan 26, 2022
@glasser glasser mentioned this issue Jan 26, 2022
Closed
@hwillson hwillson removed the ⛲️ feature New addition or enhancement to existing solutions label Jan 26, 2022
@glasser glasser self-assigned this Jan 26, 2022
glasser added a commit that referenced this issue Feb 8, 2022
@glasser
Remove apollo-server-env for now
0f2018d 
apollo-server-env is currently just a thin wrapper around node-fetch
(with our own bespoke typings for it rather than `@types/node-fetch`,
which admittedly is not currently maintained in DefinitelyTyped). We
would like to stop maintaining the wrapper in AS4 (or at least give the
package a more specific name).

Some of these uses are internal and are part of how we represent
*incoming* messages; they will be changed as part of #6038 anyway.
Others are how we talk to external services (eg usage reporting).

For now we're hardcoding all the types and defaults to be `node-fetch`,
which is pretty close to what we had before. Before releasing AS4 we
will figure out the best approach for typing fetcher options.

Part of #6046.
@glasser glasser mentioned this issue Mar 5, 2022
Closed
@glasser glasser added rebase and removed rebase labels May 12, 2022
@glasser
Copy link
Member

glasser commented Jun 21, 2022

We're feeling good about the state of the API! Leaving open #6528 for a moment to just double check that everything exported from externalTypes looks good (and maybe to move errors and expressMiddleware to nested imports).

@glasser glasser closed this as completed Jun 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glasser glasser

Labels
None yet
Projects
None yet
Milestone
Release 4.0
Development

No branches or pull requests
2 participants
@glasser @hwillson