From b962bbb1ec8d50ed910fd0cc0aeff94e1b81f201 Mon Sep 17 00:00:00 2001 From: Edward Huang Date: Wed, 23 Oct 2024 09:18:48 -0700 Subject: [PATCH 1/3] delete outdated preserve-line comments --- docs/source/getting-started.mdx | 4 ++-- docs/source/using-federation/apollo-subgraph-setup.mdx | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/source/getting-started.mdx b/docs/source/getting-started.mdx index 6e24b993b06..a662570a85b 100644 --- a/docs/source/getting-started.mdx +++ b/docs/source/getting-started.mdx @@ -153,8 +153,8 @@ Open `index.ts` in your preferred code editor and paste the following into it: ```ts title="index.ts" -import { ApolloServer } from '@apollo/server'; // preserve-line -import { startStandaloneServer } from '@apollo/server/standalone'; // preserve-line +import { ApolloServer } from '@apollo/server'; +import { startStandaloneServer } from '@apollo/server/standalone'; // A schema is a collection of type definitions (hence "typeDefs") // that together define the "shape" of queries that are executed against diff --git a/docs/source/using-federation/apollo-subgraph-setup.mdx b/docs/source/using-federation/apollo-subgraph-setup.mdx index e58a4f1f043..b4f4851132d 100644 --- a/docs/source/using-federation/apollo-subgraph-setup.mdx +++ b/docs/source/using-federation/apollo-subgraph-setup.mdx @@ -69,7 +69,7 @@ We also need to require the `buildSubgraphSchema` function from this package in ```ts title="index.ts" -import { buildSubgraphSchema } from '@apollo/subgraph'; //preserve-line +import { buildSubgraphSchema } from '@apollo/subgraph'; ``` From b19ffe33b654a682aa0f6f163dcda83c7f20d5c8 Mon Sep 17 00:00:00 2001 From: Edward Huang Date: Wed, 23 Oct 2024 10:35:10 -0700 Subject: [PATCH 2/3] add note about manual JS transpilation --- docs/source/getting-started.mdx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/source/getting-started.mdx b/docs/source/getting-started.mdx index a662570a85b..263e907cba9 100644 --- a/docs/source/getting-started.mdx +++ b/docs/source/getting-started.mdx @@ -119,6 +119,8 @@ The above `start` script tells TypeScript to compile your code into JavaScript b #### Set up with JavaScript +> All code examples in this getting started guide are in Typescript. You must transpile them to JavaScript. + If you are using JavaScript, create a `index.js` file that will contain **all** of the code for our example application: ```bash From 70adcdf6780fcbf5abd4568bcaeb3c58c7b78227 Mon Sep 17 00:00:00 2001 From: Edward Huang Date: Wed, 23 Oct 2024 11:24:53 -0700 Subject: [PATCH 3/3] typo --- docs/source/getting-started.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/getting-started.mdx b/docs/source/getting-started.mdx index 263e907cba9..50d99fa6ea8 100644 --- a/docs/source/getting-started.mdx +++ b/docs/source/getting-started.mdx @@ -119,7 +119,7 @@ The above `start` script tells TypeScript to compile your code into JavaScript b #### Set up with JavaScript -> All code examples in this getting started guide are in Typescript. You must transpile them to JavaScript. +> All code examples in this getting started guide are in TypeScript. You must transpile them to JavaScript. If you are using JavaScript, create a `index.js` file that will contain **all** of the code for our example application: