Merge pull request #313 from apollographql/pr/fix-312

more explicit `PreloadQuery` return type
apollographql · Jun 10, 2024 · 3325025 · 3325025
2 parents bef6f04 + 650f886
commit 3325025
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/client-react-streaming/src/PreloadQuery.tsx b/packages/client-react-streaming/src/PreloadQuery.tsx
@@ -35,7 +35,7 @@ export function PreloadQuery<TData, TVariables extends OperationVariables>({
     | ((
         queryRef: TransportedQueryRef<NoInfer<TData>, NoInfer<TVariables>>
       ) => ReactNode);
-}) {
+}): React.ReactElement {
   const preloadOptions = {
     ...options,
     fetchPolicy: "cache-first" as const,

diff --git a/packages/client-react-streaming/src/registerApolloClient.tsx b/packages/client-react-streaming/src/registerApolloClient.tsx
@@ -156,15 +156,15 @@ interface PreloadQueryProps<TData, TVariables>
 interface PreloadQueryComponent {
   <TData, TVariables extends OperationVariables>(
     props: PreloadQueryProps<TData, TVariables>
-  ): React.ReactNode;
+  ): React.ReactElement;
 }
 
 function makePreloadQuery(
   getClient: () => Promise<ApolloClient<any>> | ApolloClient<any>
 ) {
   return function PreloadQuery<TData, TVariables extends OperationVariables>(
     props: PreloadQueryProps<TData, TVariables>
-  ): React.ReactNode {
+  ): React.ReactElement {
     // we directly execute the bound component instead of returning JSX to keep the tree a bit tidier
     return UnboundPreloadQuery({ ...props, getClient });
   };