Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider combining the API's of Portal, OpenAPI and perhaps the Admin Service into one OpenAPI service #2079

Closed
kezhenxu94 opened this issue Mar 25, 2019 · 1 comment

Comments

@kezhenxu94
Copy link
Member

kezhenxu94 commented Mar 25, 2019

Archetecture

Taken from the wiki

Problems:

I'm thinking whether we can combine the API's of the Portal, OpenAPI and the AdminService into one OpenAPI (because they all require the same thing, manipulating configs), then the Portal UI and the users' third-party clients interact with this OpenAPI, authorization is also done there. I think this may also reduce the complexity of deployment (#1424 )

It's just a bold thought, what do you think @nobodyiam , are there other concenrs? If I've missed anything, please point it out, thanks :)

feel free to close it if it's out of scope :)

@kezhenxu94 kezhenxu94 changed the title Consider combining the API's of Portal, OpenAPI and perhaps the Admin Service Consider combining the API's of Portal, OpenAPI and perhaps the Admin Service into one OpenAPI service Mar 25, 2019
@nobodyiam
Copy link
Member

This is a bold thought to provide a real open api layer and treat portal as a standalone ui component. With this abstraction, it should be very easy to customize or even provide a fresh new ui.

However, this may involve a lot of refactoring work. Also adding one more component may bring extra effort in deployment and maintenance.

For the 4 problems described above,

  1. This might not be a problem since adding a open api service will have the same issue
  2. This involves some development work but it is not larger than refactoring the whole portal with a new open api service
  3. This makes sense, though I think it may be rare to write a fresh new portal
  4. Portal and OpenAPI now already have 2 difference authentication and authorization model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants