Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional CM sensors for CM type, revision and serial number #173

Closed
alpakpinar opened this issue Jan 19, 2023 · 0 comments · Fixed by #191
Closed

Additional CM sensors for CM type, revision and serial number #173

alpakpinar opened this issue Jan 19, 2023 · 0 comments · Fixed by #191
Labels
ZynqMonPath Related to data path to the Zynq

Comments

@alpakpinar
Copy link

Is your feature request related to a problem? Please describe.
It is not related to a specific problem. But it would be really handy if there would be sensors from the Command Module (CM) describing the type, revision and serial number, which can be read out by the OpenIPMC. This would also make it possible to read out those values even if the Zynq is not booting.

Describe the solution you'd like
Ideally, since OpenIPMC supports numerical sensors, one CM sensor for each piece of information could be used:

CM Type: Maybe this can be represented as an enum. For example, 0 -> Cornell CM, 1 -> MPI CM
CM Revision: The CM revision number can be provided by this sensor.
CM Serial: The CM serial number can be provided by this sensor.

With these CM sensors, the goal would be to see three additional sensors in the output of the ipmitool sensor command.

Describe alternatives you've considered
One variation can be in the number of CM sensors to be added. It could be nice if there is a single CM sensor that represents all type, revision and serial information, but it is not clear how that can be easily encoded/decoded on the OpenIPMC side and displayed to the user.

Another alternative is to write these values to Zynq registers (which I believe most of it is already there), the downside would be then we won't be able to read these values if Zynq didn't boot.

Additional context
This is a rather low priority request, thanks for considering it and let us know if you have suggestions about this! I'll include @dgastler here as the original requester of the feature.

@pwittich pwittich added the ZynqMonPath Related to data path to the Zynq label Mar 15, 2023
@pkotamnives pkotamnives linked a pull request Jun 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZynqMonPath Related to data path to the Zynq
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants