Bad repository link causes make init to fail

[duquale]

make init fails for this because there is an incorrect repository link in CM_FPGA_FW/.git/modules/configs/IT-DTC_p1_VU13p-1/it-dtc-fw/config on line 15

The following lines of code
[submodule "sim/LHCTriggers"] url = [email protected]:apollo-lhc/it-dtc/it-dtc-sim-libraries/lhctriggers.git

should read like this
[submodule "sim/LHCTriggers"] url = https://gitlab.com/apollo-lhc/it-dtc/it-dtc-sim-libraries/lhctriggers.git

[dgastler]

Thanks for finding this.
Could you make a branch with this fixed and make a pull request?

[duquale]

I only found this because I am currently working on getting my firmware to compile in apptainer with EMP. I had to clone a new repository for apptainer and found this error. However, my EMP compilation is still not working, and I am not sure yet if it is another problem with this git repository or something else. I can submit a pull request once I am sure there are no other problems.

[dgastler]

Can you just make a new branch and fix this one problem? Then you can merge it into both develop and your branch.
Don't fix two things in the same branch.

[duquale]

I am not sure what you mean by merge it into my branch. What I meant was that I did not want to submit a pull request now only to find another problem tomorrow and have to submit another pull request to fix that.

Regardless, I started to submit the pull request, but I discovered that the problem is more complicated than I realized. The problem can be fixed by simply changing both of these lines of code:
./.git/modules/configs/IT-DTC_p1_VU13p-1/it-dtc-fw/config:14: url = [email protected]:apollo-lhc/it-dtc/it-dtc-sim-libraries/lhctriggers.git
./configs/IT-DTC_p1_VU13p-1/it-dtc-fw/.gitmodules:3: url = [email protected]:apollo-lhc/it-dtc/it-dtc-sim-libraries/lhctriggers.git
to
url = https://gitlab.com/apollo-lhc/it-dtc/it-dtc-sim-libraries/lhctriggers.git

However, these two files are autogenerated upon make init, so you have to alter the files after they are created during make init failing and then run make init again. I do not know how to fix it in repository. The files do not exist in CM_FPGA_FW, so I am guessing it is a problem with the Makefile, https://gitlab.com/apollo-lhc/it-dtc, or some combination.

[duquale]

As far as I can tell, make init is writing that pushurl instead of the proper url. For all of the other repositories, it properly writes the correct pushurl or url as needed. It seems to me that there are two lists somewhere that define which repositories are called with pushurls and which are called with urls, so lhctriggers.git is simply in the wrong one. I can't find those lists though.