Review: AmirAli SeyedZadegan

[alirezaopmc]

Dear @L000Pz

Thanks for submitting your awesome plugin here and providing a delightful README. 🌷

Check this one out and I will share any issues I find. We can discuss on them to fix them. 🙋🏻‍♂️

Note that it would be great if you ensure me that this repository will be up to date. (As I checked, this repository contains your plugin's source code. If I am wrong please provide a view access to me.)

[alirezaopmc]

Hi again @L000Pz

I was testing your plugin that I just encountered an issue.

Challenge counter will be very fast after repeating the /challenge
At the first time I used /challenge, the counter was fine. It was counting normally. Exactly 1 per second. But for the second and third time counter was counting faster. I guess it grows linearly because of storing the history of challenges in a data-structure without destroying the unsuccessful challenges.

To Reproduce
Steps to reproduce the behavior:

1. Start the server with the plain plugin with no data saved.
2. Connect two players. Let call them p1 and p2.
3. p1 command: /challenge p2
4. Wait until the counter ends.
5. Do the 3rd step again.

Expected behavior
I expected normal behavior to remain the same.

Screenshots

[L000Pz]

HELLOO and Thank you so much for submitting your problem.🙌
I am so sorry you faced this bug. I kinda was aware of the problem but I don't know why I forgot to fix it.
The problem was because I used an old code (Minecraft 1.8 old 🤦‍♂️), it's now fixed and I'll update it as soon as possible.
Thank you again for sharing this problem and if you happen to face more bugs I'd be happy to fix them for you.😉
P.S: happy you liked the README file :)