From 5685f39a46bc3b23e10b35190ad6ac7d0d400e7e Mon Sep 17 00:00:00 2001 From: Erik Djupvik Date: Thu, 29 Feb 2024 14:53:28 +0100 Subject: [PATCH 1/2] Fixes typo in button size config --- config/newsletter-foundation.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/newsletter-foundation.php b/config/newsletter-foundation.php index 63ba2f1..8bda800 100644 --- a/config/newsletter-foundation.php +++ b/config/newsletter-foundation.php @@ -58,7 +58,7 @@ 'button' => [ 'sizes' => [ - 'small' => 'Litem', + 'small' => 'Liten', 'medium' => 'Medium', 'large' => 'Stor', ], @@ -74,7 +74,7 @@ ], ], - /* + /* |-------------------------------------------------------------------------- | Image formats |-------------------------------------------------------------------------- From 36081318a0888d626abaafb83528bf12b7c954a2 Mon Sep 17 00:00:00 2001 From: Erik Djupvik Date: Tue, 12 Mar 2024 12:53:15 +0100 Subject: [PATCH 2/2] Adds url() helper to button href to prevent malformed URLs causing buttons to not render properly --- resources/views/components/button-row.blade.php | 2 +- resources/views/components/button.blade.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/views/components/button-row.blade.php b/resources/views/components/button-row.blade.php index be46e40..767fbaf 100644 --- a/resources/views/components/button-row.blade.php +++ b/resources/views/components/button-row.blade.php @@ -65,7 +65,7 @@ '#', + 'href' => '/', 'background' => config('newsletter-foundation.defaults.button.background'), 'color' => get_newsletter_text_color(config('newsletter-foundation.defaults.button.background')), 'padding' => config('newsletter-foundation.button.padding.'.config('newsletter-foundation.defaults.button.padding')), @@ -20,7 +20,7 @@ rel="noopener" class="{{ $class }}" target="_blank" - href="{{ $href }}" + href="{{ url($href) }}" style="background-color: {{ content('color') ?? $background }}; font-size: {{ $fontSize }}; font-weight: {{ $fontWeight }}; padding: {{ $padding }}; color: {{ $color }}; border-radius: {{ $borderRadius }}; border: {{ $border }}; text-decoration:none; display: {{ $display }}; mso-padding-alt: 0; text-align:center;">