Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operational transparency and control #11

Open
theganyo opened this issue Feb 15, 2016 · 2 comments
Open

Operational transparency and control #11

theganyo opened this issue Feb 15, 2016 · 2 comments

Comments

@theganyo
Copy link
Contributor

Issue #10 suggests that Bagpipes needs to have more flexibility in control and that we should consider at least some kind of notification / callback / event for pipe complete.

Going beyond that, it would be extremely useful to extend this beyond simple notifications to management functions that allow control of the process for things like stepwise control and value inspection for tracing and debugging as a pipe executes.

@osher
Copy link

osher commented Sep 28, 2016

I think that pipe fittings are implementation details of API, and in the end of it we should adhere to how API look from the outside and the common practices that come with that thinking.

In our days - it says one of two things: a callback, or a returned promise.
I'm not a fan of promises, but every callback API can be promisified thanks to myriad of solutions that do it, so I'll stick to callbacks.

What I mean is that our API should make it as easy and streight-forward as possible for our users to feature for their users this conventional APIs:
All of our users will expect a callback or will return a promise from their facade layer. So lets make handling that repetitive task a part of the service bagpipes provides

@theganyo
Copy link
Contributor Author

I agree. A simple callback-based model would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants