Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking absolute links expects URLs that are after redirect #1220

Open
metalwarrior665 opened this issue Sep 18, 2024 · 1 comment
Open
Labels
t-docs Issues owned by technical writing team.

Comments

@metalwarrior665
Copy link
Member

See for example this action check https://github.com/apify/apify-docs/actions/runs/10892978578/job/30226981711?pr=1217

It cannot resolve academy/tutorials/node-js/scraping-from-sitemaps.md which is how it exists in the filesystem. The article URL is https://docs.apify.com/academy/node-js/scraping-from-sitemaps

Do I need to bite the bullet and rename the link like that or could we resolve this so all links can work like in the filesystem? @honzajavorek @TC-MO

@B4nan
Copy link
Member

B4nan commented Sep 19, 2024

It cannot resolve academy/tutorials/node-js/scraping-from-sitemaps.md which is how it exists in the filesystem

nope, the path uses _ instead of -:

https://github.com/apify/apify-docs/blob/master/sources/academy/tutorials/node_js/scraping_from_sitemaps.md

you either use a file path or the URL

@B4nan B4nan added the t-docs Issues owned by technical writing team. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-docs Issues owned by technical writing team.
Projects
None yet
Development

No branches or pull requests

2 participants