Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag a new release #418

Closed
KDederichs opened this issue Dec 7, 2023 · 8 comments · Fixed by #426
Closed

Tag a new release #418

KDederichs opened this issue Dec 7, 2023 · 8 comments · Fixed by #426

Comments

@KDederichs
Copy link
Contributor

Hey,

since Symfony 7 support is now merged in, could you maybe tag a new release with that?

Thanks!

@ovidiuenache
Copy link

ovidiuenache commented Dec 9, 2023

Hey,

There's a problem with the Symfony 7 support because of the cebe/php-openapi package.

As you can see below, the latest version supports symfony/yaml up to version 6
image

I checked the repository and if you take a look at this issue it seems that things are moving a bit slowly lately.

I created two issues there (200 and 201) and the PR to fix them.
I'll follow those threads and come back with a reply if/when it gets merged.

We might need to consider an alternative if nothing happens and the package stays outdated.

@SpartakusMd
Copy link
Contributor

Maybe we could start thinking about switching the library? From what I see https://packagist.org/packages/devizzent/cebe-php-openapi is having pretty active development.

@franz-josef-kaiser
Copy link

As everybody (including me) seems to have that problem: Could we please have some proposal of the solution? Thanks in advance.

@dunglas
Copy link
Member

dunglas commented May 29, 2024

Maybe could we switch to this fork? https://github.com/DEVizzent/cebe-php-openapi

@franz-josef-kaiser
Copy link

franz-josef-kaiser commented May 30, 2024

@dunglas This is the one I currently forked, because of @SpartakusMd recommendation, to be able to use as a drop-in replacement (as this only works, when the repo uses the same name in composer.json). It works perfect.

For later readers and those, who are not that familiar with Composer:

# (1) Fork https://github.com/DEVizzent/cebe-php-openapi
# (2) Change name back to `cebe/php-openapi`
# (3) Switch repo and use add alias
{
  // …
  "cebe/php-openapi": "dev-master as 1.7.x-dev",
  // …
  "repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/<$NAME>/php-openapi.git"
    }
  ]
  // …
}

@soyuka
Copy link
Member

soyuka commented May 31, 2024

#425 how's that? I don't have much time to check why php 8.3 has a failure if anyone is willing to take a look thanks!

@franz-josef-kaiser
Copy link

Will try to find some time during the weekend and check. Thanks for jumping in @soyuka .

@SpartakusMd
Copy link
Contributor

I prepared the necessary changes in #426. Not sure what to do with the OpenApi 3.1 where the type may be a list of types. Added a TODO for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants