Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate json against schema from APEER #17

Open
bernhardfichtl opened this issue Jan 14, 2020 · 4 comments
Open

Validate json against schema from APEER #17

bernhardfichtl opened this issue Jan 14, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@bernhardfichtl
Copy link
Member

Currently, it is hard to locally debug issues with the module specification since the json file is not validated against the APEER schema. Therefore, it can happen that the module builds locally, but the build fails on the platform.

@nitish-tripathi
Copy link
Member

@thomasirmer can you point me the module validation endpoint? /validation/modules return 405

@nitish-tripathi nitish-tripathi self-assigned this Jan 14, 2020
@nitish-tripathi nitish-tripathi added the enhancement New feature or request label Jan 14, 2020
@bernhardfichtl
Copy link
Member Author

This should be the one, right?
https://www.apeer.com/api/module_manager/help/schemas/module_schema.json

@thomasirmer
Copy link
Contributor

thomasirmer commented Jan 15, 2020

There are two ways we could solve this

  1. We use the validation endpoint in module manager
  2. We validate against the schema directly using any JSON lib (recommended). The link to it is as @bernhardfichtl described

I do recommend we do the latter since that enables us to render our own error messages inside the module debugger. Using the api would rely on it’s response and means a dependency.

@nitish-tripathi
Copy link
Member

cool guys. Thanks for the info

@nitish-tripathi nitish-tripathi added this to the 1.2.0 milestone Jan 15, 2020
@nitish-tripathi nitish-tripathi removed this from the 1.2.0 milestone Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants