Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up _data/members.json #20

Open
ErikBoesen opened this issue May 22, 2020 · 2 comments
Open

Clean up _data/members.json #20

ErikBoesen opened this issue May 22, 2020 · 2 comments

Comments

@ErikBoesen
Copy link
Member

You can allow omission of certain properties (like imagepath and label) and fallback to reasonable defaults in templating. Additionally I don't see why you need to have an object with the single key members—the whole file can just be the array of members, and that way you don't have to subscript into site.data.members.members, you can just do site.data.members.

@ErikBoesen
Copy link
Member Author

You also might want to consider using YAML since it's a lot cleaner

@ErikBoesen
Copy link
Member Author

Alternatively, if you want to keep the members key there, you might also want to add another section of the file for the three leaders at the top, who are currently hardcoded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant