[YUNIKORN-2876] Initialize queue metrics for app after queue is set #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…later after the queue placed
zhuqi-lucas
requested review from
wilfred-s,
pbacsko,
chenyulin0719 and
craigcondit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #968 +/- ##
==========================================
+ Coverage 80.95% 80.97% +0.01%
==========================================
Files 97 97
Lines 12514 12512 -2
==========================================
Hits 10131 10131
+ Misses 2113 2112 -1
+ Partials 270 269 -1 ☔ View full report in Codecov by Sentry. |
craigcondit
requested changes
Sep 16, 2024
pkg/scheduler/objects/application.go
Outdated
| metrics.GetQueueMetrics(sa.GetQueuePath()).IncQueueApplicationsNew() | ||
| func (sa *Application) SetNewMetrics() { | ||
| // ensure the queue is set before calling this function | ||
| if sa.GetQueuePath() != "" { |
There was a problem hiding this comment.
Don't add a conditional, just execute setNewMetrics() inside SetQueue(). Callers should not need to be updated at all.
There was a problem hiding this comment.
Thanks @craigcondit , good suggestion, addressed in latest PR.
craigcondit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…later after the queue placed
What is this PR for?
Currently, we push the queue app new state metrics after application objects are created, but when testing, the dynamic queue should be empty at that time, we need to do this later when we can make sure the queue placed for dynamic case.
What type of PR is it?
Todos
What is the Jira issue?
[YUNIKORN-2] Gang scheduling interface parametersHow should this be tested?
Screenshots (if appropriate)
Questions: