Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom string suffix for metrics #16954

Closed
Ayesha-Siddiqa2 opened this issue Oct 4, 2021 · 6 comments
Closed

Custom string suffix for metrics #16954

Ayesha-Siddiqa2 opened this issue Oct 4, 2021 · 6 comments
Labels
explore:control Related to the controls panel of Explore need:followup Requires followup

Comments

@Ayesha-Siddiqa2
Copy link

Ayesha-Siddiqa2 commented Oct 4, 2021

Adding custom string suffix to metrics using D3 format

Expected results
Being able to add suffixes like (GB,Mbps, dBm) using D3 format
Example: I should see xx GB when I query a particular metric

Actual results
Not able to add any string suffix in the d3 format input
Example: 826328149525 (Invalid format: 'GB')

Screenshots
Screen Shot 2021-10-04 at 15 52 54

Environment
superset version: 1.3

@junlincc junlincc added explore:control Related to the controls panel of Explore need:followup Requires followup labels Oct 6, 2021
@Ayesha-Siddiqa2
Copy link
Author

Ayesha-Siddiqa2 commented Oct 21, 2021

Found a similar issue , Is there any enhancement added for this?
#16610

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@jhult
Copy link
Contributor

jhult commented Apr 20, 2022

Bump

@stale stale bot removed the inactive Inactive for >= 30 days label Apr 20, 2022
@mdeshmu
Copy link
Contributor

mdeshmu commented Aug 9, 2022

I want to display bytes (how much size an s3 prefix is using) and now it is misleading when it format it in billion or trillion like 900B or 1.5T which isn't accurate.

@sunsikai
Copy link

+1

@rusackas
Copy link
Member

We're a lot closer to this now, as you can kind of do this with currencies. I believe you can add additional currencies in config.py. I admit, Mbps is not a currency, but you can jury rig it a bit. We'd be open to proposals/PRs that change this UI to be some sort of "metric" rather than just currency... maybe people want to add kPa, or who knows what measurements as a suffix.

image

Closing since it's a feature request rather than a bug, but again, happy to keep the discussion going or review a PR :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explore:control Related to the controls panel of Explore need:followup Requires followup
Projects
None yet
Development

No branches or pull requests

6 participants