Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49678][CORE] Support spark.test.master in SparkSubmitArguments #48126

Closed
wants to merge 1 commit into from
Closed

[SPARK-49678][CORE] Support spark.test.master in SparkSubmitArguments #48126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ private[deploy] class SparkSubmitArguments(args: Seq[String], env: Map[String, S
extends SparkSubmitArgumentsParser with Logging {
var maybeMaster: Option[String] = None
// Global defaults. These should be keep to minimum to avoid confusing behavior.
def master: String = maybeMaster.getOrElse("local[*]")
def master: String =
maybeMaster.getOrElse(System.getProperty("spark.test.master", "local[*]"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine but just curious. Why can't we just set spark.master instead? The Python documentation build actually works fine in my mac fwiw.

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can change it to accept spark.master here.

Why can't we just set spark.master instead?

For the following questions, I guess you already have #48129 to limit the number of SparkSubmit. It mitigate the situation. This PR and #48129 aims to two layers (Spark Submission and Spark local executor cores) during Python documentation generation. This PR is still valid for many core machines like c6i.24xlarge.

The Python documentation build actually works fine in my mac fwiw.

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, the reason why I didn't use spark.master directly is that it could have some side effects in K8s side. Let me check that part to make ti sure, @HyukjinKwon .

var maybeRemote: Option[String] = None
var deployMode: String = null
var executorMemory: String = null
Expand Down