Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45850][BUILD] Upgrade oracle jdbc driver to 23.3.0.23.09 #43662

Closed

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Nov 5, 2023

What changes were proposed in this pull request?

The pr aims to upgrade oracle jdbc driver from com.oracle.database.jdbc:ojdbc8:23.2.0.0 to com.oracle.database.jdbc:ojdbc11:23.3.0.23.09.

Why are the changes needed?

It is often found that Run Docker integration tests is interrupted due to OracleIntegrationSuite failure.
Several possible issues have been identified:

image
  • The oracle server version used in our GA environment is also 23.3
image

After upgrade to com.oracle.database.jdbc:ojdbc11, I attempted to trigger Run Docker integration tests 6 times (trigger date distribution: day, night or weekend, etc.), and have all been successful for the first time.
https://github.com/panbingkun/spark/actions/runs/6760572538/job/18383757692
https://github.com/panbingkun/spark/actions/runs/6765163954/job/18399468066
https://github.com/panbingkun/spark/actions/runs/6778851101/job/18465823046
https://github.com/panbingkun/spark/actions/runs/6797719942/job/18480445904
https://github.com/panbingkun/spark/actions/runs/6804543746/job/18502353511
https://github.com/panbingkun/spark/actions/runs/6809925232/job/18521970051

So, I proposed upgrading this driver first and then continuing to observe the effect.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Nov 5, 2023
@github-actions github-actions bot added the SQL label Nov 5, 2023
@panbingkun panbingkun changed the title try to fix OracleIntegrationSuite [SPARK-45850][SQL] Attempt to stabilize OracleIntegrationSuite by upgrading the oracle jdbc driver version Nov 9, 2023
@panbingkun panbingkun changed the title [SPARK-45850][SQL] Attempt to stabilize OracleIntegrationSuite by upgrading the oracle jdbc driver version [SPARK-45850][SQL] Attempt to stabilize OracleIntegrationSuite by upgrading the oracle jdbc driver Nov 9, 2023
@panbingkun panbingkun marked this pull request as ready for review November 9, 2023 13:43
@panbingkun
Copy link
Contributor Author

@LuciferYang
Copy link
Contributor

Although this may seem somewhat magical, if it can truly solve the problem, I agree to proceed with the upgrade.

@panbingkun
Copy link
Contributor Author

Although this may seem somewhat magical, if it can truly solve the problem, I agree to proceed with the upgrade.

I'm not sure if it will ultimately make OracleIntegrationSuite testing stable, but this version of the driver is more compatible with the JDK17 used by Spark and the Oracle Server version in the container. Maybe we can give it a try.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Nov 10, 2023

Although this may seem somewhat magical, if it can truly solve the problem, I agree to proceed with the upgrade.

I'm not sure if it will ultimately make OracleIntegrationSuite testing stable, but this version of the driver is more compatible with the JDK17 used by Spark and the Oracle Server version in the container. Maybe we can give it a try.

If then, please update the PR title by simply saying that Upgrade, @panbingkun .

We can merge this PR for that Java purpose.

@panbingkun panbingkun changed the title [SPARK-45850][SQL] Attempt to stabilize OracleIntegrationSuite by upgrading the oracle jdbc driver [SPARK-45850][SQL] Upgrade oracle jdbc driver to 23.3.0.23.09 Nov 10, 2023
@panbingkun panbingkun changed the title [SPARK-45850][SQL] Upgrade oracle jdbc driver to 23.3.0.23.09 [SPARK-45850][BUILD] Upgrade oracle jdbc driver to 23.3.0.23.09 Nov 10, 2023
@panbingkun
Copy link
Contributor Author

Although this may seem somewhat magical, if it can truly solve the problem, I agree to proceed with the upgrade.

I'm not sure if it will ultimately make OracleIntegrationSuite testing stable, but this version of the driver is more compatible with the JDK17 used by Spark and the Oracle Server version in the container. Maybe we can give it a try.

If then, please update the PR title by simply saying that Upgrade, @panbingkun .

We can merge this PR for that Java purpose.

Done.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Member

Merged to master. Thank you, @panbingkun and @LuciferYang .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants