-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-45850][BUILD] Upgrade oracle jdbc driver to 23.3.0.23.09 #43662
Conversation
OracleIntegrationSuite
by upgrading the oracle jdbc driver version
OracleIntegrationSuite
by upgrading the oracle jdbc driver versionOracleIntegrationSuite
by upgrading the oracle jdbc driver
Although this may seem somewhat magical, if it can truly solve the problem, I agree to proceed with the upgrade. |
I'm not sure if it will ultimately make |
If then, please update the PR title by simply saying that We can merge this PR for that Java purpose. |
OracleIntegrationSuite
by upgrading the oracle jdbc driver
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
Merged to master. Thank you, @panbingkun and @LuciferYang . |
What changes were proposed in this pull request?
The pr aims to upgrade oracle jdbc driver from
com.oracle.database.jdbc:ojdbc8:23.2.0.0
tocom.oracle.database.jdbc:ojdbc11:23.3.0.23.09
.Why are the changes needed?
It is often found that
Run Docker integration tests
is interrupted due toOracleIntegrationSuite
failure.Several possible issues have been identified:
oracle jdbc driver
currently used in Spark iscom.oracle.database.jdbc:ojdbc8
, it not for use withJDK17
.https://www.oracle.com/database/technologies/maven-central-guide.html
oracle server
version used in our GA environment is also23.3
After upgrade to
com.oracle.database.jdbc:ojdbc11
, I attempted to triggerRun Docker integration tests
6 times (trigger date distribution: day, night or weekend, etc.), and have all been successful for thefirst time
.https://github.com/panbingkun/spark/actions/runs/6760572538/job/18383757692
https://github.com/panbingkun/spark/actions/runs/6765163954/job/18399468066
https://github.com/panbingkun/spark/actions/runs/6778851101/job/18465823046
https://github.com/panbingkun/spark/actions/runs/6797719942/job/18480445904
https://github.com/panbingkun/spark/actions/runs/6804543746/job/18502353511
https://github.com/panbingkun/spark/actions/runs/6809925232/job/18521970051
So, I proposed upgrading this driver first and then continuing to observe the effect.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.