Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve Shiro's Spring Support #1576

Open
2 tasks done
bdemers opened this issue Jul 8, 2024 · 5 comments
Open
2 tasks done

[Enhancement] Improve Shiro's Spring Support #1576

bdemers opened this issue Jul 8, 2024 · 5 comments
Labels
3.x java Pull requests that update Java code spring Spring and SpringBoot
Milestone

Comments

@bdemers
Copy link
Member

bdemers commented Jul 8, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

I think, it would be better for Shiro's Spring support to integrate with Spring Security (e.g. Spring Sec, delegate to Shiro), instead of as a replacement  This would reduce a lot of code, footprint, and complexity of the integration.

Describe the solution you'd like

Create a Spring Security AuthenticationProvider that delegates to Shiro.

I've hacked on this a couple of times but I ran into a few minor issues each time, and then ran out of time to continue.

I'd love to hear other thoughts on this

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@lprimak
Copy link
Contributor

lprimak commented Jul 8, 2024

I think this is a great idea!

@lprimak lprimak added this to the 3.0.0 milestone Jul 8, 2024
@lprimak lprimak added java Pull requests that update Java code spring Spring and SpringBoot labels Jul 8, 2024
@lprimak
Copy link
Contributor

lprimak commented Jul 8, 2024

Supersedes #1236

@lprimak
Copy link
Contributor

lprimak commented Jul 9, 2024

Does this mean that Shiro/Spring can finally be configured via shiro.ini as well?

@bdemers
Copy link
Member Author

bdemers commented Jul 9, 2024

I hadn't thought about that 🤔 Possibly...

@lprimak lprimak added the 3.x label Aug 4, 2024
@SilenceLurker
Copy link

Being compatible with Spring Security and implementing it by creating an AuthenticationProvider is indeed a good idea, but it doesn't seem to address the warning from BeanPostProcessorChecker caused by ShiroFilterFactoryBean in issue #1236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x java Pull requests that update Java code spring Spring and SpringBoot
Projects
None yet
Development

No branches or pull requests

3 participants