-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Release Profile for distribution/proxy-native
#21657
Conversation
@@ -67,6 +67,35 @@ | |||
</dependencies> | |||
|
|||
<profiles> | |||
<profile> | |||
<id>release</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this PR, if you need a binary package of release distribution/proxy-native, you need to execute ./mvnw -am -pl distribution/proxy-native -B -DskipTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true - Dspotless.apply.skip=true -Pnative,release clean package
. This requires both GraalVM CE for JDK 17 and the native-image component of GraalVM installed on the device on which this command is executed. In which document should I state this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@strongduanmu I just want to make sure, does such a release note exist? 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@linghengqian I think we can add this requirement in ShardingSphere release document——https://shardingsphere.apache.org/community/cn/involved/release/shardingsphere/#3-%E5%8F%91%E5%B8%83-docker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I looked at the
Dockerfile
and release process ofdistribution/proxy
and found that all the raw materials used to build the Docker Image are extracted from the.tar.gz
file generated by the release profile. -
Is this an unwritten rule, or is it possible to make a Docker Image without making an intermediate
.tar.gz
? I'm not quite sure if.tar.gz
is only needed for distributing binaries. -
If this provision exists, I will fix the
Dockerfile
ofdistribution/proxy-native
when opening a new PR.
|
For #21347.
Changes proposed in this pull request:
distribution/proxy-native
.0.9.16
.Before committing this PR, I'm sure that I have checked the following options:
mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e
.