diff --git a/kernel/authority/core/src/main/java/org/apache/shardingsphere/authority/checker/AuthoritySQLExecutionChecker.java b/kernel/authority/core/src/main/java/org/apache/shardingsphere/authority/checker/AuthoritySQLExecutionChecker.java index 089f431080d78..42d0a37d16d74 100644 --- a/kernel/authority/core/src/main/java/org/apache/shardingsphere/authority/checker/AuthoritySQLExecutionChecker.java +++ b/kernel/authority/core/src/main/java/org/apache/shardingsphere/authority/checker/AuthoritySQLExecutionChecker.java @@ -34,7 +34,6 @@ public final class AuthoritySQLExecutionChecker implements SQLExecutionChecker { @Override public void check(final ShardingSphereMetaData metaData, final Grantee grantee, final QueryContext queryContext, final ShardingSphereDatabase database) { AuthorityRule authorityRule = metaData.getGlobalRuleMetaData().getSingleRule(AuthorityRule.class); - ShardingSpherePreconditions.checkState(new AuthorityChecker(authorityRule, grantee).isAuthorized(database.getName()), - () -> new UnknownDatabaseException(database.getName())); + ShardingSpherePreconditions.checkState(new AuthorityChecker(authorityRule, grantee).isAuthorized(database.getName()), () -> new UnknownDatabaseException(database.getName())); } } diff --git a/kernel/authority/core/src/test/java/org/apache/shardingsphere/authority/checker/AuthoritySQLExecutionCheckerTest.java b/kernel/authority/core/src/test/java/org/apache/shardingsphere/authority/checker/AuthoritySQLExecutionCheckerTest.java new file mode 100644 index 0000000000000..c3103426529e3 --- /dev/null +++ b/kernel/authority/core/src/test/java/org/apache/shardingsphere/authority/checker/AuthoritySQLExecutionCheckerTest.java @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.authority.checker; + +import org.apache.shardingsphere.authority.rule.AuthorityRule; +import org.apache.shardingsphere.infra.metadata.ShardingSphereMetaData; +import org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase; +import org.apache.shardingsphere.infra.metadata.database.rule.RuleMetaData; +import org.apache.shardingsphere.infra.session.query.QueryContext; +import org.junit.jupiter.api.Test; + +import java.util.Collections; + +import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; +import static org.mockito.Mockito.RETURNS_DEEP_STUBS; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +class AuthoritySQLExecutionCheckerTest { + + @Test + void assertCheck() { + ShardingSphereMetaData metaData = mock(ShardingSphereMetaData.class, RETURNS_DEEP_STUBS); + when(metaData.getGlobalRuleMetaData()).thenReturn(new RuleMetaData(Collections.singleton(mock(AuthorityRule.class)))); + assertDoesNotThrow(() -> new AuthoritySQLExecutionChecker().check(metaData, null, mock(QueryContext.class), mock(ShardingSphereDatabase.class))); + } +}