[ISSUE #198] support nameserver run on cgroup v2 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @caigy |
caigy
requested changes
Dec 22, 2023
Comment on lines
72
to
75
| elif [ -f /sys/fs/cgroup/cpu.max ]; then | ||
| QUOTA=$(cut -d ' ' -f 1 /sys/fs/cgroup/cpu.max) | ||
| PERIOD=$(cut -d ' ' -f 2 /sys/fs/cgroup/cpu.max) | ||
| system_cpu_cores_in_docker=$(($QUOTA/$PERIOD)) |
There was a problem hiding this comment.
It seems that 'QUOTA' may be 'max' instead of number? Pls refer this.
There was a problem hiding this comment.
yes, it maybe return number or 'max' according to https://docs.kernel.org/admin-guide/cgroup-v2.html#cgroup-v2-cpu
I would adapt it.
This was
linked to
issues
Dec 22, 2023
caigy
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
support #198
Brief changelog
Support nameserver run on cgroup v2.
Verifying this change
XXXX
Please go through this checklist to help us incorporate your contribution quickly and easily.
Notice:
It would be helpful if you could finish the following checklist (the last one is not necessary) before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.make docker-buildto build docker image for operator, try your changes from Pod inside your Kubernetes cluster, not just locally. Also provide screenshots to show that the RocketMQ cluster is healthy after the changes.make manifeststo make sure the CRD files are updated.