Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIP-379] DrainingHashEntry.refCount will increase when hashes move between existing consumers #23421

Open
lhotari opened this issue Oct 8, 2024 · 0 comments
Open

[PIP-379] DrainingHashEntry.refCount will increase when hashes move between existing consumers #23421

lhotari opened this issue Oct 8, 2024 · 0 comments
Labels
release/blocker Indicate the PR or issue that should block the release until it gets resolved

Comments

@lhotari
Copy link
Member

lhotari commented Oct 8, 2024

Background

  • drainingHashesTracker.addEntry(c, stickyKeyHash) will increase the variable DrainingHashEntry.refCount.

Issue: the variable named DrainingHashEntry.refCount will be increased repeatedly at the following scenario:

  • Register C1, assign k1 to C1
  • Register C2, move k1 to C2
    • DrainingHashEntry.refCount increases
  • Register C3, move k1 to C3
    • DrainingHashEntry.refCount increases

Originally posted by @poorbarcode in #23352 (comment)
@lhotari lhotari mentioned this issue Oct 8, 2024
Merged
4 tasks
@lhotari lhotari added the release/blocker Indicate the PR or issue that should block the release until it gets resolved label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release/blocker Indicate the PR or issue that should block the release until it gets resolved
Projects
Apache Pulsar / Key_Shared and Acknowledgement reliability and usability improvements
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lhotari