Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] protobuf-java needs to be upgraded to 3.25.5 to address CVE-2024-7254 #23341

Open
3 tasks done
lhotari opened this issue Sep 23, 2024 · 2 comments
Open
3 tasks done
Assignees
Labels
release/blocker Indicate the PR or issue that should block the release until it gets resolved type/bug The PR fixed a bug or issue reported a bug

Comments

@lhotari
Copy link
Member

lhotari commented Sep 23, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Read release policy

  • I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version

Pulsar 3.0.x, 3.3.x and master branch

Minimal reproduce step

protobuf-java needs to be upgraded to 3.25.5 to address CVE-2024-7254

What did you expect to see?

Pulsar dependencies shouldn't contain known high or critical level CVEs.

What did you see instead?

CVE-2024-7254 is categorized high although it's not a threat for Pulsar users in practice.

Anything else?

Mailing list message: https://lists.apache.org/thread/73jk2mx4nj82kxwvwgcqz5m63scqcy2s

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@lhotari lhotari added the type/bug The PR fixed a bug or issue reported a bug label Sep 23, 2024
@lhotari lhotari self-assigned this Sep 23, 2024
@lhotari
Copy link
Member Author

lhotari commented Sep 23, 2024

#22263 should be addressed while handling this.

Bookkeeper side needs to be upgraded too. There's PR apache/bookkeeper#4508 for master branch.

@lhotari lhotari added the release/blocker Indicate the PR or issue that should block the release until it gets resolved label Sep 23, 2024
@lhotari
Copy link
Member Author

lhotari commented Sep 24, 2024

It will also be necessary to handle #22263 so that a client application to later on choose to use a different protobuf-java version. protoc generated stubs are compatible only with a specific version and could break across versions. That's why client applications should be able to select the protobuf-java version going forward. Upgrading to 3.25.5 will be less impactful for client applications since they could then choose to stay on a specific version which is compatible with their protoc generated stub classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/blocker Indicate the PR or issue that should block the release until it gets resolved type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

No branches or pull requests

1 participant