Replace Jetbrains with Jakarta annotations #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: it's already done on Quarkus pr |
Correct. That's where it's from - to reduce the amount of changes from that PR |
|
Love it 😀 |
`org.jetbrains.annotations.NotNull`/`Nullable` -> `jakarta.annotations.Nonnull`/`Nullable` plus Guava's `VisibleForTesting` The Jakarta annotations are likely better supported by validation frameworks like Hibernate Validator.
snazy
force-pushed
the
jakarta-annotations
branch
from
424062b
to
e9c0c38
Compare
|
LGTM; but can we add this to the linter? I would hate to see us accidentally regress back to the wrong ones. |
| @@ -45,7 +45,7 @@ dependencies { | |||
| } | |||
| } | |||
|
|
|||
| compileOnly(libs.jetbrains.annotations) | |||
| compileOnly(libs.jakarta.annotation.api) | |||
There was a problem hiding this comment.
Or will the build changes make it impossible to accidentally use the wrong annotation?
snazy
requested review from
jbonofre,
ashvina,
RussellSpitzer,
vvcephei,
takidau,
jackye1995,
flyrain,
collado-mike,
ebyhr and
adutra
as code owners
adutra
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.jetbrains.annotations.NotNull/Nullable->jakarta.annotations.Nonnull/Nullableplus Guava'sVisibleForTestingThe Jakarta annotations are likely better supported by validation frameworks like Hibernate Validator.