Better handling of closeables in BasePolarisCatalog #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
requested review from
jbonofre,
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau,
jackye1995,
flyrain,
eric-maynard,
collado-mike and
ebyhr
as code owners
dimas-b
approved these changes
Nov 25, 2024
Comment on lines
269
to
270
| this.closeableGroup = CallContext.getCurrentContext().closeables(); | ||
| closeableGroup.addCloseable(metricsReporter()); |
There was a problem hiding this comment.
Where do these get closed now?
There was a problem hiding this comment.
When BasePolarisCatalog.close() is called.
There was a problem hiding this comment.
Sorry, I think that was my confusion. It looks like there are some objects in the CloseableGroup (the value ofmetricReporter()) that are no longer going in there. I just wanted to double-check where they are getting closed now. Does putting this in the CloseableGroup somehow still do that?
There was a problem hiding this comment.
Whoops you are right, I removed one line accidentally 🤦♂️ Thanks for spotting that, fixing.
adutra
force-pushed
the
close-catalog-fix
branch
2 times, most recently
from
bbcf373
to
4877fc3
Compare
Even if closeables are collected by `CallContext` and closed when the request finishes, it is safer to close the catalog's own cloaseables when `BasePolarisCatalog.close()` is called: this makes it possible to release resources when a test manually creates a catalog, or when the catalog is wrapped within `PolarisCatalogHandlerWrapper`. Furthermore, the "request" catalog used by PolarisCatalogHandlerWrapper is stored in `CallContext` under a different key, and closed manually in `PolarisApplication`: it is better to add the catalog to the `CallContext`'s closeables group and have it closed automatically when the `CallContext` is closed.
adutra
force-pushed
the
close-catalog-fix
branch
from
4877fc3
to
d10951d
Compare
eric-maynard
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if closeables are collected by
CallContextand closed when the request finishes, it is safer to close the catalog's own cloaseables whenBasePolarisCatalog.close()is called: this makes it possible to release resources when a test manually creates a catalog, or when the catalog is wrapped withinPolarisCatalogHandlerWrapper.Furthermore, the "request" catalog used by PolarisCatalogHandlerWrapper is stored in
CallContextunder a different key, and closed manually inPolarisApplication: it is better to add the catalog to theCallContext's closeables group and have it closed automatically when theCallContextis closed.