GH-3091: Add verification guide and .rat-excludes.txt for release #3101
+74
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulcd
commented
Dec 9, 2024
| @@ -498,6 +498,7 @@ | |||
| <consoleOutput>true</consoleOutput> | |||
| <excludes> | |||
There was a problem hiding this comment.
I am pretty sure we can change excludes for excludesFile (https://creadur.apache.org/rat/apache-rat-plugin/rat-mojo.html#excludesFile) but I am unsure why some of the regex on the individual excludes don't seem to work with excludesFile when I ran:
java -jar apache-rat-0.16.1/apache-rat-0.16.1.jar -a -d apache-parquet-1.15.0.tar.gz -E $PARQUET_SRC_FOLDER/.rat-excludes.txt
I'll investigate how to consolidate those two lists
wgtmac
reviewed
Dec 11, 2024
| @@ -91,3 +91,61 @@ Merge hash: 485658a5 | |||
| Would you like to pick 485658a5 into another branch? (y/n): | |||
| ``` | |||
| For now just say n as we have 1 branch | |||
|
|
|||
| # Release Verification | |||
There was a problem hiding this comment.
Thanks for adding this! Is it better to add this to the parquet site: https://github.com/apache/parquet-site/blob/production/content/en/docs/Contribution%20Guidelines/releasing.md?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There is currently no guide on how to verify. Having a guider will encourage people to verify the release.
This guide should be linked on the Voting thread.
What changes are included in this PR?
Added documentation about how to verify and add
.rat-excludes.txtfile with the files that do not contain a current license but we are fine with those. Those files are mainly testing.avsc,.parquet,.gitignoreandPULL_REQUEST_TEMPLATE.mdfiles.Are these changes tested?
I've validated all steps localy
Are there any user-facing changes?
No, just more docs.
Closes #3091