Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3089: Add missing license header to pom.xml #3090

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Nov 30, 2024

Rationale for this change

The license header is missing as reported on the release vote thread.

What changes are included in this PR?

Adding the missing header. It has been copied from parquet-java/parquet-cli/pom.xml

Are these changes tested?

Via CI

Are there any user-facing changes?No

Closes #3089

@raulcd
Copy link
Member Author

raulcd commented Nov 30, 2024

@Fokko FYI

@raulcd
Copy link
Member Author

raulcd commented Nov 30, 2024

The CI failure for Build Parquet with JDK 11 and gzip,snappy is not related but I seem to have seen that failure on other PRs, places like the 1.15.0 branch: https://github.com/apache/parquet-java/actions/runs/12075877527/job/33676391448
I don't seem to find an issue to track the flaky issue, I can open one.

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raulcd! I've re-triggered the failed test.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @raulcd, this seems to be the only pom.xml with the missing header.

@Fokko Fokko merged commit 0ddffb2 into apache:master Dec 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add license to pom.xml
3 participants