Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'newt new' should not do shallow copy of blinky repo #478

Open
sjanc opened this issue May 20, 2022 · 1 comment
Open

'newt new' should not do shallow copy of blinky repo #478

sjanc opened this issue May 20, 2022 · 1 comment
Assignees

Comments

@sjanc
Copy link
Contributor

sjanc commented May 20, 2022

For blinky repo we need full clone as release tag may no longer be on top of master...

[janc@ix test]$ newt new my_proj
Downloading project skeleton from apache/mynewt-blinky...
Downloading repository mynewt-blinky (commit: master) from https://github.com/apache/mynewt-blinky.git
WARNING: Creating a shallow clone by default. To unshallow repository later use "git fetch --unshallow".
Error: error: pathspec 'mynewt_1_10_0_tag' did not match any file(s) known to git

[janc@ix test]$ newt new --shallow=0 my_proj
Downloading project skeleton from apache/mynewt-blinky...
Downloading repository mynewt-blinky (commit: master) from https://github.com/apache/mynewt-blinky.git
Installing skeleton in my_proj (commit: mynewt_1_10_0_rc1_tag)
Project my_proj successfully created.

@sjanc
Copy link
Contributor Author

sjanc commented Oct 20, 2022

after more testing, we should never do shallow by default... this should be opt-in only option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants