Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler packages for appcore and netcore of nRF5340 #2535

Open
simonratner opened this issue Mar 17, 2021 · 3 comments
Open

Compiler packages for appcore and netcore of nRF5340 #2535

simonratner opened this issue Mar 17, 2021 · 3 comments

Comments

@simonratner
Copy link
Contributor

Commit disabling DSP instructions for M-33 suggests creating a custom compiler package for BSPs that need it: bafc7e0.

Given that nRF5340 appcore and netcore BSPs are in-tree, and appcore supports DSP instruction set while the netcore does not, I think the two compiler packages themselves should be in the tree: arm-none-eabi-m33 and arm-none-eabi-m33-nodsp, so that the corresponding Nordic BSPs can be used directly from the repo.

@vrahane
Copy link
Contributor

vrahane commented Apr 14, 2021

So, this can be solved by specifying pkg.cflags: for the respective BSP. apps, BSPs, targets and compiler packages when provided with pkg.cflags get applied to the entire build. cc: @ccollins476ad @vikrant-proxy

@vrahane
Copy link
Contributor

vrahane commented Apr 14, 2021

So, I think we can resolve this issue.

@simonratner
Copy link
Contributor Author

simonratner commented Apr 15, 2021

Yes, although I am not sure what the result of specifying multiple -mcpu options is. Would this prevent the compiler package from specifying a default?

I have not tested this with cflags, but with lflags the order of options is also not preserved currently, which could make this trickier (apache/mynewt-newt#429).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants