Validate scripts in global <Scripts> container

[ppkarwasz]

The ScriptsPlugin should perform a validation of the script nested configuration elements and:

• Remove the scripts that do not have a name.
• Issue a status logger warning, when this condition occurs.

[JWT007]

Hi @ppkarwasz,

So I was going to fix this but in testing realized that no script is every really created with no name.

The super-constructor for Script/ScriptRef/ScriptFile when passed a null name evaluates a default from toString().

public AbstractScript(final String name, final String language, final String scriptText) {
    this.language = language;
    this.scriptText = scriptText;
    this.name = name == null ? this.toString() : name;
}

Example: org.apache.logging.log4j.core.script.Script@7857fe2.

So by the time the array of scripts shows up in the ScriptsPlugin there are no scripts without names.

It is however a name that probably could never be sensibly referenced.

[JWT007]

@ppkarwasz what should be done with this ticket? see last comment.

Of course, the Script builders and AbstractScript constructor can be modified...

[ppkarwasz]

@ppkarwasz what should be done with this ticket? see last comment.

Of course, the Script builders and AbstractScript constructor can be modified...

Since AbstractScript.getName() is used extensively accross the code, I believe that we need an additional property (getConfiguredName()?) to allow the ScriptsPlugin to remove the scripts without an explicit name.