Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Server Command-Lines for Config-Node, Data-Node and the upcoming AI-Node #13171

Open
chrisdutz opened this issue Aug 14, 2024 · 1 comment

Comments

@chrisdutz
Copy link
Contributor

Currently the server CLI implementation of the existing nodes lacks clarity and needs a major cleaning up.

  • Use Apache Commons CLI to implement the general command-line functionality
  • Refactor the ConfigNode, DataNode and AiNode CLI parts

The syntax of the commandline issues will change to the follwing format:

{NodeCli} <options> <command>

The commands will be:

  • start
  • remove

The options will be:

  • for the remove command
    • nodeId {some node id}

To be discussed:

  • Should it be possible to remove multiple nodes, by passing in a list of ids?
  • Should it be possible to remove the current node, by omitting the nodeId parameter?
@OneSizeFitsQuorum
Copy link
Contributor

Should it be possible to remove multiple nodes, by passing in a list of ids?

+1 for removing one node per operation

Should it be possible to remove the current node, by omitting the nodeId parameter?

+1 for doing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants