[incubator-kie-issues-1439] UserTask Decouple codegen and interface from engine #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elguardian
force-pushed
the
incubator-kie-issues-1439
branch
4 times, most recently
from
3fe1ad9
to
c91d26e
Compare
elguardian
force-pushed
the
incubator-kie-issues-1439
branch
from
55eb76a
to
b30bb17
Compare
elguardian
force-pushed
the
incubator-kie-issues-1439
branch
2 times, most recently
from
1b8b2a3
to
4ca4ea0
Compare
elguardian
force-pushed
the
incubator-kie-issues-1439
branch
from
4bc99f1
to
d31149a
Compare
elguardian
force-pushed
the
incubator-kie-issues-1439
branch
from
50608d9
to
3ab38b6
Compare
elguardian
force-pushed
the
incubator-kie-issues-1439
branch
from
a2d4ccf
to
6a53583
Compare
pefernan
requested changes
Sep 16, 2024
There was a problem hiding this comment.
@elguardian everything looks fine, just found some small things.. see my comments;:
jbpm/jbpm-usertask/src/main/java/org/kie/kogito/usertask/impl/model/HumanTaskHelper.java
Outdated
Show resolved
Hide resolved
jbpm/jbpm-usertask/src/test/java/org/jbpm/usertask/impl/DeadlineHelperTest.java
Outdated
Show resolved
Hide resolved
...main/java/org/jbpm/flow/serialization/impl/marshallers/state/WorkItemNodeInstanceReader.java
Outdated
Show resolved
Hide resolved
...main/java/org/jbpm/flow/serialization/impl/marshallers/state/WorkItemNodeInstanceReader.java
Outdated
Show resolved
Hide resolved
...impl/META-INF/services/org.kie.kogito.internal.process.workitem.KogitoWorkItemHandlerFactory
Outdated
Show resolved
Hide resolved
elguardian
force-pushed
the
incubator-kie-issues-1439
branch
from
d6bf5cb
to
2562da6
Compare
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
job services are disabled and therefore deadlines are not working.
I did backward compatibility to avoid changes to a ton of tests... but it will need to be done at some point when the new rest endpoints happens
persistences is in memory
no rest endpoints. It will be done later.
depends on:apache/incubator-kie-drools#6052
Closes: apache/incubator-kie-issues#1439