[NO-ISSUE] mvel.jj license #6164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjfanning Could you kindly review how to deal with dual license?
|
pjfanning
reviewed
Nov 20, 2024
LICENSE
Outdated
| JavaParser is under dual license. Apache License Version 2.0 is chosen for mvel.jj | ||
|
|
||
| JavaParser is available either under the terms of the LGPL License or the Apache License. You as the user are entitled to choose the terms under which to adopt JavaParser. |
There was a problem hiding this comment.
I would omit the text from line 252 to line 257 since we choose Apache License as it suits our needs.
pjfanning
reviewed
Nov 20, 2024
LICENSE
Outdated
| ------------------------------------------------------------------------------------ | ||
| for drools-model/drools-mvel-parser/src/main/javacc/mvel.jj | ||
| JavaParser is under dual license. Apache License Version 2.0 is chosen for mvel.jj |
There was a problem hiding this comment.
I would suggest:
JavaParser is dual licensed under LGPL license. and Apache License Version 2.0 license. We choose the Apache License Version 2.0.
|
@pjfanning Thank you! Applied the suggestions. |
pjfanning
reviewed
Nov 20, 2024
LICENSE
Outdated
| JavaParser is dual licensed under LGPL license. and Apache License Version 2.0 license. We choose the Apache License Version 2.0. |
There was a problem hiding this comment.
Issue with full stop after 'LGPL license'. Can you remove that?
There was a problem hiding this comment.
@pjfanning Sure, thanks.
porcelli
approved these changes
Nov 20, 2024
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Nov 21, 2024
* [NO-ISSUE] mvel.jj license * - adjust words * - fixed a period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvel.jjwas taken from https://github.com/javaparser/javaparser/blob/master/javaparser-core/src/main/javacc/java.jjAccording to https://issues.apache.org/jira/browse/LEGAL-594 and https://www.apache.org/legal/resolved.html#mutually-exclusive ,
state which license you are using and include only the license that you have chosen.It's not clear to me how to "state". I have added the file path
drools-model/drools-mvel-parser/src/main/javacc/mvel.jjand the statementJavaParser is under dual license. Apache License Version 2.0 is chosen for mvel.jj, and pasted the content of https://github.com/javaparser/javaparser/blob/master/LICENSEAs the LICENSE says "For details about the Apache License please refer to LICENSE.APACHE", I keep
LICENSE.APACHEat https://github.com/apache/incubator-kie-drools/blob/main/drools-model/drools-mvel-parser/LICENSE.APACHE