adding OMG XSD files License info #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcelli
requested review from
LightGuard,
baldimir,
mariofusco and
tkobayas
tkobayas
reviewed
Nov 19, 2024
tkobayas
reviewed
Nov 19, 2024
|
FYI) In apache/incubator-kie-kogito-runtimes#3714 (comment) , @pjfanning suggested to file a LEGAL JIRA to confirm if OMG license is safe to use. Filed this : https://issues.apache.org/jira/browse/LEGAL-690 |
|
GHA rat check would pass with the change. $ git diff
diff --git a/.rat-excludes b/.rat-excludes
index f7bad0bc28..5355198b63 100644
--- a/.rat-excludes
+++ b/.rat-excludes
@@ -21,7 +21,8 @@ TestingEmptyFile\.txt
.*\.pmml_json
.*\.drl_json
.*\.dslr
-DMN.*\.xsd
+.*DMN.*\.xsd
+dmn.xsd
DC\.xsd
DI\.xsd
KiePMML.*\.txt |
8 tasks
mariofusco
approved these changes
Nov 19, 2024
pjfanning
reviewed
Nov 19, 2024
| @@ -1,4 +1,5 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
|
|
|||
There was a problem hiding this comment.
is there a reason to add all the blank lines?
There was a problem hiding this comment.
no particular reason other than have all related files in the same commit :)
tkobayas
reviewed
Nov 20, 2024
Comment on lines
1
to
19
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
|
|
There was a problem hiding this comment.
@porcelli Per the email conversation, we don't need to remove this header? If it's intentional and you plan to re-add the header later (maybe we will check with ASF), this PR would be fine to merge.
There was a problem hiding this comment.
agree, will revert this
yesamer
approved these changes
Nov 20, 2024
LightGuard
approved these changes
Nov 20, 2024
tkobayas
pushed a commit
to tkobayas/drools
that referenced
this pull request
Nov 21, 2024
* adding OMG XSD files License info * fixing rat-excludes and adjusting file list of OMG files * adjusted trisotech related license and copyright info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.