Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO_ISSUE] Change log level from error to debug inside ImportDMNResolverUtil #6150

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

gitgabrio
Copy link
Contributor

@gitgabrio gitgabrio commented Nov 13, 2024

Currently, the ImportDMNResolverUtil#resolveImportDMN(Import, Collection<T>, Function<T, QName>) log an error message if a matching imported model can't be found in the given Collection.

Unfortunately, the DMNValidatorImpl#processDMNResourcesAndValidate(DMNMessageManager, List<DMNResource>) (indirectly) invokes it with an empty collection, always leading to misleading "error" message logged.

That message logging has been introduced recently, but the actual behavior did not change, so setting it to "debug" has not any backward/behavior impact.

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@gitgabrio
Copy link
Contributor Author

kogito-runtimes failure unrelated

apache_incubator-kie-kogito-runtimes/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/StandaloneBPMNProcessTest.java:405 | expected: 2 but was: 1

@gitgabrio gitgabrio merged commit 2447ce1 into apache:main Nov 14, 2024
7 of 9 checks passed
@gitgabrio gitgabrio deleted the fix_log_level branch November 14, 2024 07:27
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants