Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Incubator-kie-issues#1605] DMN JIT Executor successfully executing invalid DMN #6146

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

AthiraHari77
Copy link
Contributor

@AthiraHari77 AthiraHari77 commented Nov 7, 2024

Fixes apache/incubator-kie-issues#1605

Needed by apache/incubator-kie-kogito-apps#2142

This PR introduce a new "invalid" model to be used as test

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@AthiraHari77 AthiraHari77 changed the title [Incubator-kie-issues#(1605)](DMN JIT Executor successfully executing invalid DMN) [Incubator-kie-issues#1605]-DMN JIT Executor successfully executing invalid DMN Nov 7, 2024
@gitgabrio gitgabrio changed the title [Incubator-kie-issues#1605]-DMN JIT Executor successfully executing invalid DMN [Incubator-kie-issues#1605] DMN JIT Executor successfully executing invalid DMN Nov 7, 2024
@gitgabrio gitgabrio marked this pull request as ready for review November 7, 2024 11:03
Copy link
Contributor

@gitgabrio gitgabrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AthiraHari77 ! Welcome aboard!

Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AthiraHari77, well done :)

@yesamer yesamer added the DMN label Nov 12, 2024
@gitgabrio gitgabrio merged commit e67b193 into apache:main Nov 15, 2024
21 of 22 checks passed
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMN JIT Executor successfully executing invalid DMN
3 participants