Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-drools-6136] Migrate droos test coverage module to JUnit5 - #2 #6139

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

pibizza
Copy link
Contributor

@pibizza pibizza commented Oct 29, 2024

Second group of tests in drools test coverage migrated to JUnit5.
If you love getting bored this is a patch for you to review.

Issue:

[https://github.com//issues/6136]

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@pibizza
Copy link
Contributor Author

pibizza commented Oct 30, 2024

Downstreams failures are unrelated.

@mariofusco mariofusco merged commit 6b2d92d into apache:main Oct 31, 2024
8 of 9 checks passed
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Nov 7, 2024
…it5 - apache#2 (apache#6139)

* More tests migrated to JUnit5

* More tests migrated

* More unit tests migrated to JUnit5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants