Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1497] Defining NodeInstanceContainer.getSerializableNodeInstances to be used during serialization #6116

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

gitgabrio
Copy link
Contributor

@gitgabrio gitgabrio commented Oct 8, 2024

Fixes apache/incubator-kie-issues#1497

Required by
apache/incubator-kie-kogito-runtimes#3707

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

…zableNodeInstances to be used during serialization
Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gitgabrio
Copy link
Contributor Author

kogito-runtimes failure unrelated
apache_incubator-kie-kogito-runtimes/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/StandaloneBPMNProcessTest.java:407 | expected: 2 but was: 1

serverless-workflow-examples failure unrelated
mvn <args> -rf :serverless-workflow-python-quarkus

@gitgabrio gitgabrio merged commit 7e38588 into apache:main Oct 18, 2024
7 of 9 checks passed
@gitgabrio gitgabrio deleted the incubator-kie-issues#1497 branch October 18, 2024 10:39
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Oct 24, 2024
…zableNodeInstances to be used during serialization (apache#6116)

Co-authored-by: Gabriele-Cardosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kogito 10-rc: Protobuf Serialization error with Multi-instance subprocess.
4 participants