kie-issues#1601: removing binary files and disabling tests associated…

… with those (#6141)
apache · Nov 3, 2024 · 4afd234 · 4afd234
1 parent b880a9b
commit 4afd234
Show file tree

Hide file tree

Showing 29 changed files with 27 additions and 1 deletion.
diff --git a/drools-compiler/src/test/resources/JarWithSourceFiles.jar b/drools-compiler/src/test/resources/JarWithSourceFiles.jar
diff --git a/drools-compiler/src/test/resources/KAModelTest.jar b/drools-compiler/src/test/resources/KAModelTest.jar
diff --git a/drools-compiler/src/test/resources/eventing-example.jar b/drools-compiler/src/test/resources/eventing-example.jar
diff --git a/drools-compiler/src/test/resources/primespoc.jar b/drools-compiler/src/test/resources/primespoc.jar
diff --git a/drools-legacy-test-util/src/test/resources/billasurf.jar b/drools-legacy-test-util/src/test/resources/billasurf.jar
diff --git a/...rialization-protobuf/src/test/java/org/drools/serialization/protobuf/MarshallingTest.java b/...rialization-protobuf/src/test/java/org/drools/serialization/protobuf/MarshallingTest.java
@@ -875,6 +875,7 @@ private void unsetPrivateKeyProperties() {
      * In this case we are dealing with facts which are not on the systems classpath.
      */
     @Test
+    @Ignore ("ignored due use of binary resource, which is not allowed in Apache source release.")
     public void testSerializabilityWithJarFacts() throws Exception {
         MapBackedClassLoader loader = new MapBackedClassLoader( this.getClass().getClassLoader() );
 

diff --git a/...compiler-integration/src/test/java/org/drools/mvel/integrationtests/DynamicRulesTest.java b/...compiler-integration/src/test/java/org/drools/mvel/integrationtests/DynamicRulesTest.java
@@ -899,6 +899,7 @@ public void testDynamicRuleAdditionsWithEntryPoints() throws Exception {
     }
 
     @Test(timeout=10000)
+    @Ignore ("ignored due use of binary resource, which is not allowed in Apache source release.")
     public void testIsolatedClassLoaderWithEnumsPkgBuilder() throws Exception {
         try {
             // Creates first class loader and use it to load fact classes
@@ -948,6 +949,7 @@ public void testIsolatedClassLoaderWithEnumsPkgBuilder() throws Exception {
     }
 
     @Test(timeout=10000)
+    @Ignore ("ignored due use of binary resource, which is not allowed in Apache source release.")
     public void testIsolatedClassLoaderWithEnumsContextClassloader() throws Exception {
         try {
             // Creates first class loader and use it to load fact classes

diff --git a/...test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/JBRULESTest.java b/...test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/JBRULESTest.java
@@ -39,6 +39,7 @@
 import org.drools.testcoverage.common.util.KieBaseUtil;
 import org.drools.testcoverage.common.util.KieUtil;
 import org.drools.testcoverage.common.util.TestParametersUtil;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -313,6 +314,7 @@ public void testJBRULES3326() throws Exception {
     }
 
     @Test
+    @Ignore ("ignored due use of binary resource, which is not allowed in Apache source release.")
     public void testGUVNOR578_2() throws Exception {
         // An internal specific test case so not enhanced for executable-model
         final MapBackedClassLoader loader = new MapBackedClassLoader( this.getClass().getClassLoader() );

diff --git a/...ompiler-integration/src/test/java/org/drools/mvel/integrationtests/KieRepositoryTest.java b/...ompiler-integration/src/test/java/org/drools/mvel/integrationtests/KieRepositoryTest.java
@@ -21,6 +21,7 @@
 import java.net.URL;
 import java.net.URLClassLoader;
 
+import org.junit.Ignore;
 import org.junit.Test;
 import org.kie.api.KieServices;
 import org.kie.api.builder.KieModule;
@@ -29,6 +30,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
+@Ignore("ignored due use of binary resource, which is not allowed in Apache source release.")
 public class KieRepositoryTest {
 
     @Test

diff --git a/...iler-integration/src/test/java/org/drools/mvel/integrationtests/MBeansMonitoringTest.java b/...iler-integration/src/test/java/org/drools/mvel/integrationtests/MBeansMonitoringTest.java
@@ -39,6 +39,7 @@
 import org.drools.testcoverage.common.util.TestParametersUtil;
 import org.junit.After;
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -529,6 +530,7 @@ private void checkAgendaTotals(GenericKieSessionMonitoringMXBean mb, long mCreat
      * Copied from KieRepositoryTest to test JMX monitoring
      */
     @Test
+    @Ignore("ignored due use of binary resource, which is not allowed in Apache source release.")
     public void testLoadKjarFromClasspath() {
         // DROOLS-1335
         ClassLoader cl = Thread.currentThread().getContextClassLoader();

diff --git a/...e/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/Misc2Test.java b/...e/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/Misc2Test.java
@@ -6993,6 +6993,7 @@ public void testJittedConstraintStringAndLong() {
     }
 
     @Test
+    @Ignore ("ignored due use of binary resource, which is not allowed in Apache source release.")
     public void testKieBuilderWithClassLoader() {
         // DROOLS-763
         String drl =

diff --git a/drools-test-coverage/test-compiler-integration/src/test/resources/billasurf.jar b/drools-test-coverage/test-compiler-integration/src/test/resources/billasurf.jar
diff --git a/...s-test-coverage/test-compiler-integration/src/test/resources/kie-project-simple-1.0.0.jar b/...s-test-coverage/test-compiler-integration/src/test/resources/kie-project-simple-1.0.0.jar
diff --git a/.../test-compiler-integration/src/test/resources/only-jar-pojo-not-kjar-no-kmodule-1.0.0.jar b/.../test-compiler-integration/src/test/resources/only-jar-pojo-not-kjar-no-kmodule-1.0.0.jar
diff --git a/...egration/src/test/resources/org/drools/mvel/compiler/compiler/xml/changeset/changeset.jar b/...egration/src/test/resources/org/drools/mvel/compiler/compiler/xml/changeset/changeset.jar
diff --git a/drools-test-coverage/test-compiler-integration/src/test/resources/testEnum.jar b/drools-test-coverage/test-compiler-integration/src/test/resources/testEnum.jar
diff --git a/drools-verifier/drools-verifier-drl/src/test/java/org/drools/verifier/VerifierTest.java b/drools-verifier/drools-verifier-drl/src/test/java/org/drools/verifier/VerifierTest.java
@@ -31,6 +31,7 @@
 import org.drools.verifier.data.VerifierReport;
 import org.drools.verifier.report.components.Severity;
 import org.drools.verifier.report.components.VerifierMessageBase;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.kie.api.io.ResourceType;
 
@@ -69,6 +70,7 @@ void testVerifier() {
     }
 
     @Test
+    @Disabled("disabled due use of binary resource, which is not allowed in Apache source release.")
     void testFactTypesFromJar() {
         VerifierBuilder vBuilder = VerifierBuilderFactory.newVerifierBuilder();
 
@@ -114,6 +116,7 @@ void testFactTypesFromJar() {
     }
 
     @Test
+    @Disabled("disabled due use of binary resource, which is not allowed in Apache source release.")
     void testFactTypesFromJarAndDeclarations() {
         VerifierBuilder vBuilder = VerifierBuilderFactory.newVerifierBuilder();
 

diff --git a/...ols-verifier-drl/src/test/java/org/drools/verifier/jarloader/PackageHeaderLoaderTest.java b/...ols-verifier-drl/src/test/java/org/drools/verifier/jarloader/PackageHeaderLoaderTest.java
@@ -28,12 +28,13 @@
 import org.drools.verifier.Verifier;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.fail;
 
-
+@Disabled("disabled due use of binary resource, which is not allowed in Apache source release.")
 public class PackageHeaderLoaderTest {
 
     private ArrayList<JarInputStream> jarInputStreams;

diff --git a/...ier-drl/src/test/java/org/drools/verifier/jarloader/VerifierMapBackedClassLoaderTest.java b/...ier-drl/src/test/java/org/drools/verifier/jarloader/VerifierMapBackedClassLoaderTest.java
@@ -23,6 +23,7 @@
 import java.util.jar.JarInputStream;
 
 import org.drools.verifier.Verifier;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import static org.assertj.core.api.Assertions.assertThat;
@@ -33,6 +34,7 @@
 public class VerifierMapBackedClassLoaderTest {
 
     @Test
+    @Disabled("disabled due use of binary resource, which is not allowed in Apache source release.")
     void testCheckResources() throws Exception {
         ArrayList<JarInputStream> jarInputStreams = new ArrayList<JarInputStream>();
         jarInputStreams.add(new JarInputStream(Verifier.class.getResourceAsStream("model.jar")));

diff --git a/drools-verifier/drools-verifier-drl/src/test/resources/org/drools/verifier/model.jar b/drools-verifier/drools-verifier-drl/src/test/resources/org/drools/verifier/model.jar
diff --git a/.../efesto-common-api/src/test/java/org/kie/efesto/common/api/utils/MemoryFileUtilsTest.java b/.../efesto-common-api/src/test/java/org/kie/efesto/common/api/utils/MemoryFileUtilsTest.java
@@ -25,6 +25,7 @@
 import java.net.URL;
 import java.util.Optional;
 
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.kie.efesto.common.api.io.MemoryFile;
 
@@ -57,6 +58,7 @@ void getFileFromFileNameOrFilePathNotExisting() {
     }
 
     @Test
+    @Disabled("disabled due use of binary resource, which is not allowed in Apache source release.")
     void getFileFromURL() throws IOException {
         URL url = getJarUrl();
         assertThat(url).isNotNull();
@@ -74,6 +76,7 @@ void getFileFromURL() throws IOException {
     }
 
     @Test
+    @Disabled("disabled due use of binary resource, which is not allowed in Apache source release.")
     void getOptionalFileFromJar() throws IOException {
         URL jarUrl = getJarUrl();
         assertThat(jarUrl).isNotNull();
@@ -111,6 +114,7 @@ void getFileFromResource() throws IOException {
     }
 
     @Test
+    @Disabled("disabled due use of binary resource, which is not allowed in Apache source release.")
     void getFileFromJar() throws URISyntaxException, IOException {
         URL jarUrl = getJarUrl();
         assertThat(jarUrl).isNotNull();

diff --git a/efesto/efesto-core/efesto-common-api/src/test/resources/TestJar.jar b/efesto/efesto-core/efesto-common-api/src/test/resources/TestJar.jar
diff --git a/...core/efesto-common-core/src/test/java/org/kie/efesto/common/core/utils/JSONUtilsTest.java b/...core/efesto-common-core/src/test/java/org/kie/efesto/common/core/utils/JSONUtilsTest.java
@@ -25,6 +25,7 @@
 import java.util.Optional;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.kie.efesto.common.api.identifiers.LocalUri;
 import org.kie.efesto.common.api.identifiers.ModelLocalUriId;
@@ -153,6 +154,7 @@ void getGeneratedResourcesObjectFromFile() throws Exception {
     }
 
     @Test
+    @Disabled("disabled due use of binary resource, which is not allowed in Apache source release.")
     void getGeneratedResourcesObjectFromJar() throws Exception {
         ClassLoader originalClassLoader = addJarToClassLoader();
         Optional<File> optionalIndexFile = getFileFromFileName("IndexFile.testb_json");

diff --git a/efesto/efesto-core/efesto-common-core/src/test/resources/TestJar.jar b/efesto/efesto-core/efesto-common-core/src/test/resources/TestJar.jar
diff --git a/...re/src/test/java/org/kie/efesto/runtimemanager/core/utils/GeneratedResourceUtilsTest.java b/...re/src/test/java/org/kie/efesto/runtimemanager/core/utils/GeneratedResourceUtilsTest.java
@@ -22,6 +22,7 @@
 import java.net.URLClassLoader;
 import java.util.Optional;
 
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.kie.efesto.common.api.identifiers.LocalUri;
 import org.kie.efesto.common.api.identifiers.ModelLocalUriId;
@@ -58,6 +59,7 @@ void getGeneratedRedirectResourceFromFile() {
     }
 
     @Test
+    @Disabled("disabled due use of binary resource, which is not allowed in Apache source release.")
     void getGeneratedRedirectResourceFromJar() {
         ClassLoader originalClassLoader = addJarToClassLoader();
         ModelLocalUriId modelLocalUriId = new ModelLocalUriId(LocalUri.parse("/testb/redirecttestmod"));

diff --git a/...to-core/efesto-runtime-manager/efesto-runtime-manager-core/src/test/resources/TestJar.jar b/...to-core/efesto-runtime-manager/efesto-runtime-manager-core/src/test/resources/TestJar.jar
diff --git a/kie-ci/src/test/java/org/kie/scanner/KieModuleMavenTest.java b/kie-ci/src/test/java/org/kie/scanner/KieModuleMavenTest.java
@@ -34,6 +34,7 @@
 import org.drools.base.factmodel.ClassDefinition;
 import org.drools.base.factmodel.FieldDefinition;
 import org.drools.mvel.asm.DefaultBeanClassBuilder;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.kie.api.KieBase;
 import org.kie.api.KieServices;
@@ -212,6 +213,7 @@ public void testKieModulePojoDependencies() throws Exception {
     }
 
     @Test
+    @Ignore ("ignored due use of binary resource, which is not allowed in Apache source release.")
     public void testKieContainerBeforeAndAfterDeployOfSnapshot() throws Exception {
         // BZ-1007977
         KieServices ks = KieServices.Factory.get();

diff --git a/kie-ci/src/test/resources/kjar/kjar-module-after.jar b/kie-ci/src/test/resources/kjar/kjar-module-after.jar
diff --git a/kie-ci/src/test/resources/kjar/kjar-module-before.jar b/kie-ci/src/test/resources/kjar/kjar-module-before.jar