-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: define Hudi error types across hudi-core #124
Conversation
6c52a4b
to
2f6f596
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 91.78% 90.53% -1.26%
==========================================
Files 20 21 +1
Lines 962 1004 +42
==========================================
+ Hits 883 909 +26
- Misses 79 95 +16 ☔ View full report in Codecov by Sentry. |
@gohalo any plan to resume the work here by resolving conflicts first? we've cut release branch so master won't have much changes for some time. |
OK, will fix that next week |
@gohalo do you have time to resume work on this? in case you're occupied, maybe @TheR1sing3un could take this over? as this is more of a foundational work, we want to move forward sooner, ideally land this within the next 7 days. thanks! |
working on that, still have some conflicts to fix now |
6db9499
to
8413a3a
Compare
8413a3a
to
c43dad7
Compare
@xushiyan the conflicts have fixed, i will check the coverage recently, you could review the code first. |
c43dad7
to
10d82d0
Compare
Signed-off-by: GoHalo <[email protected]>
10d82d0
to
1249a4e
Compare
Thanks for the fix! will go through this today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! I just marked some small changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall is good. i'll make a follow up pr to refine error categories.
I'll work on a follow up PR to get the coverage level back. merging it now. |
Description
Use
thiserror
instead ofanyhow
to define the error for hudi-core crate.#72
How are the changes test-covered