Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define Hudi error types across hudi-core #124

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

gohalo
Copy link
Contributor

@gohalo gohalo commented Aug 31, 2024

Description

Use thiserror instead of anyhow to define the error for hudi-core crate.

#72

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@gohalo gohalo changed the title [wip] refact: define Hudi error types across hudi-core refact: define Hudi error types across hudi-core Sep 10, 2024
@gohalo
Copy link
Contributor Author

gohalo commented Sep 10, 2024

@xushiyan @codope
Hope this codes could be reviewed as soon as possible, because it refact the core crate, and almost every new merged code should refact again. 😊

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 71.92982% with 32 lines in your changes missing coverage. Please review.

Project coverage is 90.53%. Comparing base (a2738da) to head (02c659b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/storage/utils.rs 57.14% 6 Missing ⚠️
crates/core/src/table/builder.rs 37.50% 5 Missing ⚠️
python/src/internal.rs 0.00% 5 Missing ⚠️
crates/core/src/table/mod.rs 20.00% 4 Missing ⚠️
crates/core/src/table/partition.rs 55.55% 4 Missing ⚠️
crates/core/src/storage/mod.rs 76.92% 3 Missing ⚠️
crates/core/src/config/internal.rs 60.00% 2 Missing ⚠️
crates/core/src/config/table.rs 93.54% 2 Missing ⚠️
crates/core/src/table/timeline.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   91.78%   90.53%   -1.26%     
==========================================
  Files          20       21       +1     
  Lines         962     1004      +42     
==========================================
+ Hits          883      909      +26     
- Misses         79       95      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gohalo gohalo changed the title refact: define Hudi error types across hudi-core refactor: define Hudi error types across hudi-core Sep 11, 2024
@xushiyan xushiyan added refactor Code refactoring without any functionality or behavior change rust Related to Rust codebase labels Sep 15, 2024
@xushiyan xushiyan added this to the release-0.3.0 milestone Sep 15, 2024
@xushiyan xushiyan linked an issue Sep 15, 2024 that may be closed by this pull request
@xushiyan
Copy link
Member

@gohalo any plan to resume the work here by resolving conflicts first? we've cut release branch so master won't have much changes for some time.

@gohalo
Copy link
Contributor Author

gohalo commented Nov 21, 2024

OK, will fix that next week

@xushiyan
Copy link
Member

xushiyan commented Nov 30, 2024

@gohalo do you have time to resume work on this? in case you're occupied, maybe @TheR1sing3un could take this over? as this is more of a foundational work, we want to move forward sooner, ideally land this within the next 7 days. thanks!

@gohalo
Copy link
Contributor Author

gohalo commented Dec 2, 2024

@gohalo do you have time to resume work on this? in case you're occupied, maybe @TheR1sing3un could take this over? as this is more of a foundational work, we want to move forward sooner, ideally land this within the next 7 days. thanks!

working on that, still have some conflicts to fix now

@xushiyan xushiyan self-assigned this Dec 2, 2024
@xushiyan xushiyan added p0 feature python Related to Python codebase p1 and removed refactor Code refactoring without any functionality or behavior change p0 labels Dec 2, 2024
@gohalo
Copy link
Contributor Author

gohalo commented Dec 3, 2024

@xushiyan the conflicts have fixed, i will check the coverage recently, you could review the code first.

Signed-off-by: GoHalo <[email protected]>
@xushiyan
Copy link
Member

xushiyan commented Dec 3, 2024

@xushiyan the conflicts have fixed, i will check the coverage recently, you could review the code first.

Thanks for the fix! will go through this today.

Copy link
Contributor

@jonathanc-n jonathanc-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! I just marked some small changes.

crates/core/src/lib.rs Outdated Show resolved Hide resolved
crates/core/src/lib.rs Show resolved Hide resolved
crates/core/src/lib.rs Show resolved Hide resolved
crates/core/src/config/table.rs Outdated Show resolved Hide resolved
crates/core/src/config/table.rs Outdated Show resolved Hide resolved
Copy link
Member

@xushiyan xushiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall is good. i'll make a follow up pr to refine error categories.

crates/core/src/config/read.rs Outdated Show resolved Hide resolved
crates/core/src/config/read.rs Outdated Show resolved Hide resolved
crates/core/src/storage/mod.rs Show resolved Hide resolved
@xushiyan xushiyan changed the title refactor: define Hudi error types across hudi-core feature: define Hudi error types across hudi-core Dec 5, 2024
@xushiyan xushiyan changed the title feature: define Hudi error types across hudi-core feat: define Hudi error types across hudi-core Dec 5, 2024
@xushiyan
Copy link
Member

xushiyan commented Dec 5, 2024

I'll work on a follow up PR to get the coverage level back. merging it now.

@xushiyan xushiyan merged commit 12c60ac into apache:main Dec 5, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature p1 python Related to Python codebase rust Related to Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants